Skip to content

Commit 0ce10c8

Browse files
jcbhmrjcbhmr
authored
refactor: Fix linter stuff (#28)
1 parent 8247c2d commit 0ce10c8

File tree

8 files changed

+119
-116
lines changed

8 files changed

+119
-116
lines changed

‎.devcontainer/devcontainer.json

+10-10
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
2-
"image": "mcr.microsoft.com/devcontainers/javascript-node",
3-
"features": {
4-
"ghcr.io/devcontainers/features/docker-in-docker": {}
5-
},
6-
"postCreateCommand": "npm install -g @devcontainers/cli",
7-
"customizations": {
8-
"vscode": {
9-
"extensions": ["mads-hartmann.bash-ide-vscode"]
10-
}
11-
}
2+
"image": "mcr.microsoft.com/devcontainers/javascript-node",
3+
"features": {
4+
"ghcr.io/devcontainers/features/docker-in-docker": {}
5+
},
6+
"postCreateCommand": "npm install -g @devcontainers/cli",
7+
"customizations": {
8+
"vscode": {
9+
"extensions": ["mads-hartmann.bash-ide-vscode"]
10+
}
11+
}
1212
}

‎.github/workflows/test.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ on:
55
- main
66
pull_request:
77
workflow_dispatch:
8-
8+
permissions:
9+
contents: read
910
jobs:
1011
test-autogenerated:
1112
runs-on: ubuntu-latest

‎.gitignore

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
megalinter-reports
2+
logs
3+
*.log

‎.vscode/settings.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
2-
"json.schemas": [
3-
{
4-
"fileMatch": ["*/devcontainer-feature.json"],
5-
"url": "https://raw.githubusercontent.com/devcontainers/spec/main/schemas/devContainerFeature.schema.json"
6-
}
7-
]
2+
"json.schemas": [
3+
{
4+
"fileMatch": ["*/devcontainer-feature.json"],
5+
"url": "https://raw.githubusercontent.com/devcontainers/spec/main/schemas/devContainerFeature.schema.json"
6+
}
7+
]
88
}

‎README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ my favorite color is green
5454

5555
## Repo and Feature Structure
5656

57-
Similar to the [`devcontainers/features`](https://github.com/devcontainers/features) repo, this repository has a `src` folder. Each Feature has its own sub-folder, containing at least a `devcontainer-feature.json` and an entrypoint script `install.sh`.
57+
Similar to the [`devcontainers/features`](https://github.com/devcontainers/features) repo, this repository has a `src` folder. Each Feature has its own sub-folder, containing at least a `devcontainer-feature.json` and an entrypoint script `install.sh`.
5858

5959
```
6060
├── src
@@ -149,7 +149,7 @@ https://github.com/users/<owner>/packages/container/<repo>%2F<featureName>/setti
149149
If you'd like your Features to appear in our [public index](https://containers.dev/features) so that other community members can find them, you can do the following:
150150

151151
* Go to [github.com/devcontainers/devcontainers.github.io](https://github.com/devcontainers/devcontainers.github.io)
152-
* This is the GitHub repo backing the [containers.dev](https://containers.dev/) spec site
152+
* This is the GitHub repo backing the [containers.dev](https://containers.dev/) spec site
153153
* Open a PR to modify the [collection-index.yml](https://github.com/devcontainers/devcontainers.github.io/blob/gh-pages/_data/collection-index.yml) file
154154

155155
This index is from where [supporting tools](https://containers.dev/supporting) like [VS Code Dev Containers](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers) and [GitHub Codespaces](https://github.com/features/codespaces) surface Features for their dev container creation UI.

‎src/dart/NOTES.md

+44-45
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,44 @@
1-
<!-- markdownlint-disable MD041 MD033 -->
2-
3-
<div align="center">
4-
5-
[![Dart website](https://thum.io/get/width/800/crop/600/noanimate/https://dart.dev/)](https://dart.dev/)
6-
7-
</div>
8-
9-
> Dart is a client-optimized language for fast apps on any platform
10-
11-
&mdash; [Dart programming language | Dart]
12-
13-
This feature installs the Dart SDK.
14-
15-
🆘 If you're having trouble with this feature, [open a Discussion] or [open an
16-
Issue]! We'd be happy to fix bugs! 🐛
17-
18-
## Supported platforms
19-
20-
`linux/amd64` and `linux/arm64` platforms `debian` and `ubuntu`.
21-
22-
## How to specify extensions?
23-
24-
This feature installs any version with the `version` option and `channel` option.
25-
Check [Dart SDK archive] for channel details.
26-
27-
```json
28-
"features": {
29-
"ghcr.io/devcontainers-community/features/dart:1": {
30-
"version": "3",
31-
"channel": "beta"
32-
}
33-
}
34-
```
35-
36-
Note that the beta and dev channels use suffix-based version matching,
37-
so only versions ending with channel name (e.g. `3.1.0-63.1.beta`) can be installed.
38-
39-
<!-- prettier-ignore-start -->
40-
[Dart programming language | Dart]: https://dart.dev/
41-
[Dart SDK archive]: https://dart.dev/get-dart/archive
42-
[Flutter]: https://flutter.dev/
43-
[open a Discussion]: https://github.com/devcontainers-community/features/discussions/new?category=q-a
44-
[open an Issue]: https://github.com/devcontainers-community/features/issues/new
45-
<!-- prettier-ignore-end -->
1+
<!-- markdownlint-disable MD041 MD033 -->
2+
3+
<div align="center">
4+
5+
[![Dart website](https://thum.io/get/width/800/crop/600/noanimate/https://dart.dev/)](https://dart.dev/)
6+
7+
</div>
8+
9+
> Dart is a client-optimized language for fast apps on any platform
10+
11+
&mdash; [Dart programming language | Dart]
12+
13+
This feature installs the Dart SDK.
14+
15+
🆘 If you're having trouble with this feature, [open a Discussion] or [open an
16+
Issue]! We'd be happy to fix bugs! 🐛
17+
18+
## Supported platforms
19+
20+
`linux/amd64` and `linux/arm64` platforms `debian` and `ubuntu`.
21+
22+
## How to specify extensions?
23+
24+
This feature installs any version with the `version` option and `channel` option.
25+
Check [Dart SDK archive] for channel details.
26+
27+
```json
28+
"features": {
29+
"ghcr.io/devcontainers-community/features/dart:1": {
30+
"version": "3",
31+
"channel": "beta"
32+
}
33+
}
34+
```
35+
36+
Note that the beta and dev channels use suffix-based version matching,
37+
so only versions ending with channel name (e.g. `3.1.0-63.1.beta`) can be installed.
38+
39+
<!-- prettier-ignore-start -->
40+
[Dart programming language | Dart]: https://dart.dev/
41+
[Dart SDK archive]: https://dart.dev/get-dart/archive
42+
[open a Discussion]: https://github.com/devcontainers-community/features/discussions/new?category=q-a
43+
[open an Issue]: https://github.com/devcontainers-community/features/issues/new
44+
<!-- prettier-ignore-end -->

‎src/dart/devcontainer-feature.json

+28-28
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
1-
{
2-
"id": "dart",
3-
"name": "Dart",
4-
"description": "Installs the Dart SDK",
5-
"version": "1.0.0",
6-
"options": {
7-
"version": {
8-
"description": "Select version of Dart SDK",
9-
"type": "string",
10-
"default": "latest",
11-
"proposals": ["latest", "3"]
12-
},
13-
"channel": {
14-
"description": "Select build channel of Dart SDK",
15-
"type": "string",
16-
"default": "stable",
17-
"enum": ["stable", "beta", "dev", "main"]
18-
}
19-
},
20-
"containerEnv": {
21-
"PATH": "/usr/lib/dart/bin:${PATH}"
22-
},
23-
"customizations": {
24-
"vscode": {
25-
"extensions": ["dart-code.dart-code"]
26-
}
27-
}
28-
}
1+
{
2+
"id": "dart",
3+
"name": "Dart",
4+
"description": "Installs the Dart SDK",
5+
"version": "1.0.0",
6+
"options": {
7+
"version": {
8+
"description": "Select version of Dart SDK",
9+
"type": "string",
10+
"default": "latest",
11+
"proposals": ["latest", "3"]
12+
},
13+
"channel": {
14+
"description": "Select build channel of Dart SDK",
15+
"type": "string",
16+
"default": "stable",
17+
"enum": ["stable", "beta", "dev", "main"]
18+
}
19+
},
20+
"containerEnv": {
21+
"PATH": "/usr/lib/dart/bin:${PATH}"
22+
},
23+
"customizations": {
24+
"vscode": {
25+
"extensions": ["dart-code.dart-code"]
26+
}
27+
}
28+
}

‎test/dart/scenarios.json

+24-24
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
11
{
2-
"version-3": {
3-
"image": "mcr.microsoft.com/devcontainers/base:debian",
4-
"features": {
5-
"dart": {
6-
"version": "3"
7-
}
8-
}
9-
},
10-
"channel-beta": {
11-
"image": "mcr.microsoft.com/devcontainers/base:debian",
12-
"features": {
13-
"dart": {
14-
"channel": "beta"
15-
}
16-
}
17-
},
18-
"channel-main": {
19-
"image": "mcr.microsoft.com/devcontainers/base:debian",
20-
"features": {
21-
"dart": {
22-
"channel": "main"
23-
}
24-
}
25-
}
2+
"version-3": {
3+
"image": "mcr.microsoft.com/devcontainers/base:debian",
4+
"features": {
5+
"dart": {
6+
"version": "3"
7+
}
8+
}
9+
},
10+
"channel-beta": {
11+
"image": "mcr.microsoft.com/devcontainers/base:debian",
12+
"features": {
13+
"dart": {
14+
"channel": "beta"
15+
}
16+
}
17+
},
18+
"channel-main": {
19+
"image": "mcr.microsoft.com/devcontainers/base:debian",
20+
"features": {
21+
"dart": {
22+
"channel": "main"
23+
}
24+
}
25+
}
2626
}

0 commit comments

Comments
 (0)