Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't add @types/ws if webSocket shim is enabled but the test option is set to false #409

Open
rojvv opened this issue May 17, 2024 · 3 comments

Comments

@rojvv
Copy link
Contributor

rojvv commented May 17, 2024

No description provided.

@dsherret
Copy link
Member

dsherret commented May 17, 2024

Can you post reproduction code? Actually, is this during type checking that it fails? (while building?)

@dsherret
Copy link
Member

I think a simple fix would be to just include @types packages from transformOutput.test.dependencies when type checking:

const testDevDependencies = testEnabled

@rojvv
Copy link
Contributor Author

rojvv commented May 17, 2024

Yes, it is while building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants