Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map npm workspace packages to JSR specifiers on publish if npm package in workspace is a jsr package? #23638

Closed
dsherret opened this issue May 1, 2024 · 0 comments · Fixed by #24507
Closed

Map npm workspace packages to JSR specifiers on publish if npm package in workspace is a jsr package? #23638

dsherret opened this issue May 1, 2024 · 0 comments · Fixed by #24507
Labels
jsr Issues or feature requests relating to JSR.io suggestion suggestions for new features (yet to be agreed) workspaces

Comments

@dsherret
Copy link
Member

dsherret commented May 1, 2024

Consider the following scenario:

  • package-a
  • package-b

...where package-b refers to package-a via an npm workspace dependency. Both package-a and package-b are npm packages and jsr packages. Maybe in this scenario, the npm workspace dependencies to package-a should be changed to prefer be a reference to the jsr package instead. Probably this should only be done on publish and just use the npm package w/ node resolution otherwise.

Related: jsr-io/jsr#448
@dsherret dsherret added suggestion suggestions for new features (yet to be agreed) jsr Issues or feature requests relating to JSR.io labels May 1, 2024
@dsherret dsherret mentioned this issue May 1, 2024
Open
@dsherret dsherret mentioned this issue Jul 10, 2024
Merged
dsherret added a commit that referenced this issue Jul 10, 2024
@dsherret
feat(jsr): support publishing jsr packages in npm workspaces (#24507)
4d2d764 
Supports publishing an npm workspace with a directory structure similar
to the following:

- workspace
  - package.json
  - package-a
    - package.json
    - jsr.json
  - package-b
    - package.json
    - jsr.json

deno_config PR: denoland/deno_config#77

Closes #23638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jsr Issues or feature requests relating to JSR.io suggestion suggestions for new features (yet to be agreed) workspaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(jsr): support publishing jsr packages in npm workspaces dsherret/deno
1 participant
@dsherret