-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weird enlarging of image in gallery #1025
Comments
https://developer.apple.com/documentation/quicklook/qlpreviewcontrollerdelegate/1617007-previewcontroller?language=objc looks promising to improve the transition animation for all previewed items (e.g. documents, images in the chat, too). I'll play with that a little bit |
great! if that gets too complicated, however, as said, just closing the preview is also fine for now. |
playing around with that for a day, i'd say it is fine to just always close on pressing preview-image/docs/whatever. our preview is probably not integrate enough to make this really a smooth ux. but even when this is the case: there are also large images, texts etc. that may make it hard to close the preview. eg. also other apps close the preview on pressing preview-image (whatsapp), so it is not unexpected. therefore, my suggestion:
this is probably very easy to implement and does not raise new issues as the inability to close preview. |
for the new gallery-context-menu, at #985 (comment) i suggested that a tap inside the preview-image of the context-menu should directly enlarges the image; similar to the ios gallery.
some changes were done, however, the current state is not really nice :)
a tap on the preview-image first closes the preview with some animation and then, with another animation, the fullscreen-view is opened. this looks weird and is imho unexpected to the user. normally, animations should help to follow what is going on, this is not the case here.
so, we should either:
for 2., that is probably just some code-removal. so, i would be fine with 2. as well :)
The text was updated successfully, but these errors were encountered: