Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the 'Add Second Device' QR code bigger #3466

Closed
exelotl opened this issue Dec 4, 2024 · 2 comments
Closed

Make the 'Add Second Device' QR code bigger #3466

exelotl opened this issue Dec 4, 2024 · 2 comments
Labels

Comments

@exelotl
Copy link

exelotl commented Dec 4, 2024

I attempted to add my laptop as a second device, but was unable to scan the QR code generated by Delta Chat on my phone, because the image picked up by my laptop's webcam was too blurry.

I then took a screenshot on my phone, and zoomed in so that the QR code took up the entire width of the screen instead of only half the width (before doing so there was ~25% dead space either side). After doing that, the code was read easily.

  • Android version: 10
  • Device: LG Nexus 5
  • Delta Chat version: 1.48.3
@exelotl exelotl added the bug label Dec 4, 2024
@r10s
Copy link
Member

r10s commented Dec 4, 2024

indeed, the "add second device" qr code may contain more infomation and may be more dense than the add-contact one - but both use the same rendering and size

(the used device, however, is also old and probably has a comparable low-resolution :) but great, there is android10 available for that, btw, i have the same device, however , the screen broke some time ago, maybe i should try to revive it :)

however, we aim to get rid of the old rendering anyways, for "add second device", this could mean to render the QR code at the same place, but without the gray border.

the text "Scan to set up second device for ..." can go where currently the "experimental" warning is.

i think, that would look better in general, and might solve the issue as the code could be a bit bigger

@adbenitez
Copy link
Member

hi @exelotl thanks for the feedback! I think we can close this as a duplicated of #3381 since it is about dropping/changing the current QR layout

in a bigger picture, often desktop computers have much worse cameras (if any!) than phones and we should invert the scanning QR workflow to always scan from phone so there is no need to look like a mad person moving the phone in front of your webcam 😅

@adbenitez adbenitez closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants