Add RandomFrom overloads

[delphidabbler]

There are RandomFrom functions in System.Math for all the Float array types + Integer, Int64 and UInt64 arrays.

There also RandomFrom functions in System.AnsiStrings and System.StrUtils for arrays of ANSI and Unicode strings.

What's missing are RandomFrom overloads for Cardinal arrays (+ shorter Integer types), TBytes and TStrings.

[delphidabbler]

I've created a TStrings RandomFrom overload in CodeSnip. Here's the source:

function RandomString(const SL: TStrings): string; overload;
begin
  if SL.Count = 0 then
    raise ERangeError.Create('RandomString called with empty string list');
  Result := SL[Random(SL.Count)];
end;

[delphidabbler]

What's missing are RandomFrom overloads for Cardinal arrays (+ shorter Integer types), TBytes and TStrings.

Note that Delphi 12 now has the following overloads, so we don't need the Cardinal and TBytes overloads anymore:

function RandomFrom(const AValues: array of ShortInt): ShortInt; overload;
function RandomFrom(const AValues: array of SmallInt): SmallInt; overload;
function RandomFrom(const AValues: array of Integer): Integer; overload;
function RandomFrom(const AValues: array of Int64): Int64; overload;
function RandomFrom(const AValues: array of Byte): Byte; overload;
function RandomFrom(const AValues: array of Word): Word; overload;
function RandomFrom(const AValues: array of Cardinal): Cardinal; overload;
function RandomFrom(const AValues: array of UInt64): UInt64; overload;
function RandomFrom(const AValues: array of Single): Single; overload;
function RandomFrom(const AValues: array of Double): Double; overload;
function RandomFrom(const AValues: array of Extended): Extended; overload;
function RandomFrom(const AValues: array of Boolean): Boolean; overload;

[delphidabbler]

I've created a TStrings RandomFrom overload in CodeSnip. Here's the source:

function RandomString(const SL: TStrings): string; overload;
begin
  if SL.Count = 0 then
    raise ERangeError.Create('RandomString called with empty string list');
  Result := SL[Random(SL.Count)];
end;

This routine has its own issue: #28.

[delphidabbler]

There are so many overloads of RandomFrom in the Delphi RTL that it really isn't worth implementing any more. Furthermore, the proposed RandomString function in issue #28 means there is no need for a string list overload of RandomFrom.

Therefore this issue is being rejected and closed.