-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vatican.requestHandler #23
Comments
@smart--petea the method "isAbsolute" does not seem to be part of the "path" module: http://nodejs.org/api/path.html |
I'm working with experimental node with support for generators (version 0.11.*). But version 0.10.32 (the current stable version) support the |
@smart--petea please make sure you don't add code from experimental versions of Node on your PRs. Thanks |
You are right. I misunderstood their source code from version 0.10.32 - https://github.com/joyent/node/blob/v0.10.32-release/lib/path.js. There they use |
In Vatican.requestHandler there is the snippet
If options.handlers is defined as relative path all it's ok. If options.handlers is defined as absolute paths the
methodFound.handlerPath
is an absolute path and the expressionprocess.cwd() + "/" + methodFound.handlerPath
will give something likeplus an error of reading the directory.
Maybe
path
moduleVatican.parseHandlers
Vatican.requestHandler
The text was updated successfully, but these errors were encountered: