Skip to content

Commit db0ed5c

Browse files
committedDec 15, 2023
wiki: update GerritAccess for wiki
Change-Id: I45e8b88e1f92cbacd29dbbf6c2a678108d2a2372 Reviewed-on: https://go-review.googlesource.com/c/wiki/+/549798 Reviewed-by: Russ Cox <[email protected]>
1 parent 8b14004 commit db0ed5c

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed
 

‎GerritAccess.md

+10-6
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ There are two types of Gerrit access described here, with different powers & res
99
## Running TryBots ("may-start-trybots")
1010

1111
TryBot access lets you kick off a test run of a CL in Gerrit prior to submission (pre-submit testing).
12-
TryBots run in a somewhat-secure and somewhat-isolated environment,
12+
TryBots run in a somewhat-secure and somewhat-isolated environment,
1313
but they're not perfectly security hardened.
1414
You must skim the CL for anything malicious before starting TryBots.
1515

@@ -39,25 +39,29 @@ To request approver access, see [Requesting Access](#requesting-access) below.
3939

4040
### Auto-Submit
4141

42-
If you are reviewing a CL and believe it can be approved and submitted as is,
43-
with no further changes, you can use the auto-submit functionality
44-
to run tests and submit the CL if the tests pass.
42+
If you are reviewing a CL and believe it can be approved and submitted as is,
43+
with no further changes, you can use the auto-submit functionality
44+
to run tests and submit the CL if the tests pass.
4545
To do this, vote Code-Review+2 as well as Auto-Submit+1 and Run-TryBot+1. When the tests pass, Gopherbot will submit it.
4646

4747
More precisely, Gopherbot watches for and automatically submits CLs that
4848

4949
- have Auto-Submit+1 and TryBot-Result+1 votes,
50-
- have the necessary code reviews,
50+
- have the necessary code reviews,
5151
- have no unresolved comments,
5252
- aren't marked #wait-release,
5353
- and merge cleanly into the current branch head.
5454

5555
All approvers can add Auto-Submit+1 votes.
5656
An Auto-Submit+1 vote is not carried forward when a patch is reuploaded.
5757

58+
## Approving Wiki CLs ("wiki-approvers")
59+
60+
People who work mainly in the wiki (https://go.googlesource.com/wiki) can request wiki-approvers permission. This lets them +2 and submit wiki CLs, even their own CLs. Wiki CLs do not require the involvement of two (or any) Google employees, they have no TryBots, and they can be self-reviewed.
61+
5862
# Requesting Access
5963

60-
To get request either of the access types above, file a bug (https://github.com/golang/go/issues/new?title=access:+&body=See+https://go.dev/wiki/GerritAccess) and list and state which access you want, and state the Google account you use to log in to Gerrit.
64+
To get request any of the access types above, file a bug (https://github.com/golang/go/issues/new?title=access:+&body=See+https://go.dev/wiki/GerritAccess) and list and state which access you want, and state the Google account you use to log in to Gerrit.
6165

6266
Decisions about granting access are made by the Go release team at Google. If your request is declined, it is almost always because you haven't been active enough for them to get a clear enough signal about your work, understanding of project conventions, and so on. Don't lose heart: it can take time to reach that level of familiarity.
6367

0 commit comments

Comments
 (0)
Please sign in to comment.