You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: GerritAccess.md
+10-6
Original file line number
Diff line number
Diff line change
@@ -9,7 +9,7 @@ There are two types of Gerrit access described here, with different powers & res
9
9
## Running TryBots ("may-start-trybots")
10
10
11
11
TryBot access lets you kick off a test run of a CL in Gerrit prior to submission (pre-submit testing).
12
-
TryBots run in a somewhat-secure and somewhat-isolated environment,
12
+
TryBots run in a somewhat-secure and somewhat-isolated environment,
13
13
but they're not perfectly security hardened.
14
14
You must skim the CL for anything malicious before starting TryBots.
15
15
@@ -39,25 +39,29 @@ To request approver access, see [Requesting Access](#requesting-access) below.
39
39
40
40
### Auto-Submit
41
41
42
-
If you are reviewing a CL and believe it can be approved and submitted as is,
43
-
with no further changes, you can use the auto-submit functionality
44
-
to run tests and submit the CL if the tests pass.
42
+
If you are reviewing a CL and believe it can be approved and submitted as is,
43
+
with no further changes, you can use the auto-submit functionality
44
+
to run tests and submit the CL if the tests pass.
45
45
To do this, vote Code-Review+2 as well as Auto-Submit+1 and Run-TryBot+1. When the tests pass, Gopherbot will submit it.
46
46
47
47
More precisely, Gopherbot watches for and automatically submits CLs that
48
48
49
49
- have Auto-Submit+1 and TryBot-Result+1 votes,
50
-
- have the necessary code reviews,
50
+
- have the necessary code reviews,
51
51
- have no unresolved comments,
52
52
- aren't marked #wait-release,
53
53
- and merge cleanly into the current branch head.
54
54
55
55
All approvers can add Auto-Submit+1 votes.
56
56
An Auto-Submit+1 vote is not carried forward when a patch is reuploaded.
57
57
58
+
## Approving Wiki CLs ("wiki-approvers")
59
+
60
+
People who work mainly in the wiki (https://go.googlesource.com/wiki) can request wiki-approvers permission. This lets them +2 and submit wiki CLs, even their own CLs. Wiki CLs do not require the involvement of two (or any) Google employees, they have no TryBots, and they can be self-reviewed.
61
+
58
62
# Requesting Access
59
63
60
-
To get request either of the access types above, file a bug (https://github.com/golang/go/issues/new?title=access:+&body=See+https://go.dev/wiki/GerritAccess) and list and state which access you want, and state the Google account you use to log in to Gerrit.
64
+
To get request any of the access types above, file a bug (https://github.com/golang/go/issues/new?title=access:+&body=See+https://go.dev/wiki/GerritAccess) and list and state which access you want, and state the Google account you use to log in to Gerrit.
61
65
62
66
Decisions about granting access are made by the Go release team at Google. If your request is declined, it is almost always because you haven't been active enough for them to get a clear enough signal about your work, understanding of project conventions, and so on. Don't lose heart: it can take time to reach that level of familiarity.
0 commit comments