Skip to content

Location bar shouldn’t update until success #319

@clipperhouse

Description

@clipperhouse

I notice that pushState is called before the request is sent or a response is received, which means user’s location bar updates to the new URL prior to receiving a response.

Normal browser behavior for non-ajax navigation does not update the location bar until a response comes back. So, from a user’s perspective, the URL change is premature. I’d recommend simply removing line 339’s call to pushState, and simply let replaceState be called on success.

Perhaps there is a reason for this behavior that I am unaware of, in which case please correct.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions