Location bar shouldn’t update until success

[clipperhouse]

I notice that pushState is called before the request is sent or a response is received, which means user’s location bar updates to the new URL prior to receiving a response.

Normal browser behavior for non-ajax navigation does not update the location bar until a response comes back. So, from a user’s perspective, the URL change is premature. I’d recommend simply removing line 339’s call to pushState, and simply let replaceState be called on success.

Perhaps there is a reason for this behavior that I am unaware of, in which case please correct.

[EmmanuelVella]

+1

[layerssss]

+1 for this, it's the browser behaviour without pjax

[taka-oyama]

+1

[AlexHill]

+1, this is also the source of a bug: if the request fails and the link target is hard-fetched, the HTTP_REFERER header is set to the target's address instead of the current page.

In my case the subsequent view redirected back to HTTP_REFERER - redirect loop!

[Nelrann]

+1

[mikkotikkanen]

Didn't read the code through and through, just wanted to add this: ok as long as it does the same with failed request as well, since fe. 404 pages (which should have 404 status) need to be inserted to the history as well (and if http code is not 200, jquery ajax call triggers the fail handler)

[mislav]

This is a complex issue. Closing in favor of the discussion in #334