feat: add an install.sh script #1034
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
reviewed
Dec 10, 2024
Comment on lines
+14
to
+17
| An `install.sh` file is also available for installation with curl (requires `sudo`): | ||
| ``` | ||
| curl -sSL https://raw.githubusercontent.com/defenseunicorns/uds-cli/main/install.sh | bash | ||
| ``` |
There was a problem hiding this comment.
I think I'd prefer something more like the zarf docs here: https://docs.zarf.dev/getting-started/install/#github-releases
Essentially it just provides the curl, chmod, and mv commands you'd need to grab the right binary per your system, in easy copy/paste blocks. I think it still meets the desire of providing an alternative install mechanism that's relatively simple, but avoids the (1) potential suspect nature of piping a curl-ed script right to a shell and (2) keeps it simple and trusts the end user to know their platform. Open to other opinions here though. I think this is generally in line with zarf as linked, but also kubectl (which also teaches additional good habits like verifying the sha, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds an install.sh script to automate the process of downloading the latest available binary for
uds-cli. The script identifies the latest release, downloads the appropriate binary for the user’s operating system and architecture, and verifies it installs. This improves the user experience by simplifying the installation process.Related Issue
Relates to #1033
Type of change
Checklist before merging