-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(validation)!: #266 validation.ValidationCommand no longer returns error if validation was run #267
Conversation
… an error when the validation has been successfully run fix(validator)!: validator.Validate() no longer returns the parsed basic output as an error and instead returns the jsonschema.ValidationError fix(cmd): validate cmd updated to handle ValidationCommand & validator.Validate changes
…n-true-errors-and-validationerrors-when-using-validationcommand
…ssue opened to resolve the GetValidationResult returning an error
…d of validationResponse.JsonSchemaError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves the identified issue. Currently prints both to stdout and the outputfile if specified - maybe that is intentional and otherwise doesn't block merge.
intentional for now, not opposed to removing the log when the output file is set, I just always like my failures in the logs even if I am outputting. |
Description
Reworked the ValidationCommand and v.Validate() return values to make it more clear when a non validation error has been thrown by changing the above methods to handle errors and validation errors separately using the
ValidationResponse
andValidationResult
types.ValidationCommand
&validator.Validate
changesValidationResponse
gained theJsonSchemaError *jsonschema.ValidationError
fieldRelated Issue
#266
Type of change
Checklist before merging