You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what should be investigated or refactored
I have noticed a lot of frustrations when consuming go-oscal as a library both within itself and within Lula. Many of the issues I have run into would likely be solved by not passing around instantiated "empty" structs, by replacing many of the structs with pointers, it opens it up to simple nil checks and also ensures json compatibility with go-oscalLibrary types and consistency with Lula and this projects own generated types
Describe what should be investigated or refactored
I have noticed a lot of frustrations when consuming
go-oscal
as a library both within itself and within Lula. Many of the issues I have run into would likely be solved by not passing around instantiated "empty"structs
, by replacing many of the structs with pointers, it opens it up to simple nil checks and also ensures json compatibility withgo-oscal
Library types and consistency with Lula and this projects own generated typesLinks to any relevant code
struct
:go-oscal/src/pkg/validation/validator.go
Lines 98 to 103 in 004addd
Additional context
catalyst for creating this issue:
Add any other context or screenshots about the technical debt here.
The text was updated successfully, but these errors were encountered: