fix(validation): unclear distinction between "true" errors and "validationErrors" when using ValidationCommand #266
Comments
mike-winberry
added
bug
5 tasks
mike-winberry
added a commit
that referenced
this issue
Jun 18, 2024
… an error when the validation has been successfully run fix(validator)!: validator.Validate() no longer returns the parsed basic output as an error and instead returns the jsonschema.ValidationError fix(cmd): validate cmd updated to handle ValidationCommand & validator.Validate changes
5 tasks
5 tasks
mike-winberry
added a commit
that referenced
this issue
Jun 18, 2024
… error if validation was run (#267) * fix(validation)!: #266 validation.ValidationCommand no longer returns an error when the validation has been successfully run fix(validator)!: validator.Validate() no longer returns the parsed basic output as an error and instead returns the jsonschema.ValidationError fix(cmd): validate cmd updated to handle ValidationCommand & validator.Validate changes * fix(validation_command): added safety err handling with commment to issue opened to resolve the GetValidationResult returning an error * fix(cmd): validate cmd now returns the Result json as an error instead of validationResponse.JsonSchemaError
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
validation.ValidationCommandshould returnerror == nilwhen validation is successfully executed regardless of wether or not there areValidationErrorspresent as those can be handled using theValidationResponse.Resultvalidator.Validate()should no longer return thebasicErrorsand instead return thejsonschema.ValidatonErrorto allow for additional handling by the consumer of the original jsonschema errorValidationResponsevia theJsonSchemaErrorfield of type*jsonschema.ValidationErrorAdditional context
The text was updated successfully, but these errors were encountered: