generate_expert_config.py issues

[y-he2]

Directly running the example command in the README:

python scripts/expert/generate_expert_config.py \
    --eval_datasets=intent,summary,law,translation \
    --expert_scores_dir=results/expert_scores \
    --output_dir=results/expert_configs \
    --score_function=token \
    --top_p=0.2 # the scoring function and top_p are hyperparameters

raised:
generate_expert_config.py: error: the following arguments are required: --eval_dataset, --output_path

Looked into the script it reads:

    parser.add_argument("--eval_dataset", type=str, required=True)
    parser.add_argument("--expert_scores_dir", type=str, required=True)
    parser.add_argument("--output_path", type=str, required=True)
    parser.add_argument("--score_function", type=str, required=True)
    parser.add_argument("--top_p", type=float, required=True)
    parser.add_argument("--train_shared_experts", action="store_true")
    parser.add_argument("--train_non_expert_modules", action="store_true")

After changed the example command to:
python scripts/expert/generate_expert_config.py
--eval_dataset=summary
--expert_scores_dir=results/expert_scores
--output_path=results/expert_configs
--score_function=token --top_p=0.2
raised:

..../generate_expert_config.py", line 96, in <module>
    with open(args.output_path, "w") as f:
IsADirectoryError: [Errno 21] Is a directory: 'results/expert_configs'

Suspect the doc is outdated, pls update the doc or code accordingly. Specifically:
eval_dataset vs eval_datasets;
output_path vs output_dir;