Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#719 - Support decoration with process information #720

Closed
wants to merge 3 commits into from

Conversation

dbo
Copy link

@dbo dbo commented Jul 25, 2019

Implements #719

Feedback welcome.

@coveralls
Copy link

coveralls commented Jul 25, 2019

Coverage Status

Coverage increased (+1.9%) to 89.547% when pulling dfe3ae1 on dbo:master into 5c7c61d on visionmedia:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.1%) to 89.789% when pulling d92b3f9 on dbo:master into 5c7c61d on visionmedia:master.

@Qix-
Copy link
Member

Qix- commented Jul 26, 2019

Really not a fan of adding more environment variables - this is what #556 is aimed to solve. Otherwise, every logging combination under the sun would scope-creep this package into oblivion.

@dbo
Copy link
Author

dbo commented Jul 26, 2019

@Qix- Apparently it's not really about my own logs only (which I could customize with what is aimed in #556), but about 3rd party NPMs that I use in my process. Moreover, environment variables don't require to execute any custom code which is sometimes not possible when plugging into frameworks that use their own startup scripts. Since all debug env variables are scoped to DEBUG_ I don't see any collision.

@Qix-
Copy link
Member

Qix- commented Jul 26, 2019

It's not about collision, it's about API cleanliness. The idea behind #556 is that it'd be globally enforced and entirely backwards compatible. You wouldn't have to modify code, but instead use -r to inject a non-default reporter.

In the case of PID's, #582 could include PID as a variable.

@dbo
Copy link
Author

dbo commented Jul 27, 2019

@Qix- I agree, reading on #582 I think it's what I look for, since I could streamline all logs to carry the PID (needs some %P or whatever extension though) or define a readable process title.

@dbo dbo closed this Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants