Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build system #655

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Remove build system #655

merged 1 commit into from
Dec 19, 2018

Conversation

Qix-
Copy link
Member

@Qix- Qix- commented Dec 19, 2018

Closes #652.

This completely removes browserify from the mix (at publish time) and greatly simplifies the codebase.

The only compilation happening is for running tests in Karma (headless chrome), at which point we don't care about how it's packaged - more that it runs, and runs to completion.

@Qix- Qix- added the change-patch This proposes or provides a change that requires a patch release label Dec 19, 2018
@Qix- Qix- added this to the 5.x milestone Dec 19, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 86.561% when pulling 355445c on remove-build into 0e94034 on master.

@coveralls
Copy link

coveralls commented Dec 19, 2018

Coverage Status

Coverage decreased (-0.3%) to 86.561% when pulling 8be5486 on remove-build into 0e94034 on master.

@Qix- Qix- mentioned this pull request Dec 19, 2018
11 tasks
@Qix-
Copy link
Member Author

Qix- commented Dec 19, 2018

Not entirely sure why coveralls is whining here. It's just noise.

@Qix- Qix- merged commit 94583b6 into master Dec 19, 2018
@Qix- Qix- deleted the remove-build branch December 19, 2018 03:35
@debug-js debug-js locked as resolved and limited conversation to collaborators Dec 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
change-patch This proposes or provides a change that requires a patch release
Development

Successfully merging this pull request may close these issues.

2 participants