Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to example on readme returning 404 pages #927

Open
davidekete opened this issue Mar 6, 2023 · 3 comments
Open

Links to example on readme returning 404 pages #927

davidekete opened this issue Mar 6, 2023 · 3 comments
Labels
bug This issue identifies a malfunction change-patch This proposes or provides a change that requires a patch release needs-documentation This issue or change requires additional documentation

Comments

@davidekete
Copy link

Screenshot 2023-03-06 at 12 31 14 PM
Please review or remove links to examples in your readme. Links such as the stdout.js in the screenshot above return a 404 page.
@Qix-
Copy link
Member

Qix- commented Mar 6, 2023

Yeah the Readme needs a lot of love. The examples aren't there anymore, they were mostly pointless as the readme has a ton of examples already (debug is not a hard package to use).

I'll keep this open to remind myself of this when I finally get to the readme. Thanks for letting me know :)

@Qix- Qix- added bug This issue identifies a malfunction change-patch This proposes or provides a change that requires a patch release needs-documentation This issue or change requires additional documentation labels Mar 6, 2023
@davidekete
Copy link
Author

Let me know if you need any help. I can help fix the readme.

@mitant
Copy link

mitant commented Jul 20, 2023

I've added example files matching the original README links in the following PR. I also updated the code to pass linting and updated the README with the new lint-friendly code.

#938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue identifies a malfunction change-patch This proposes or provides a change that requires a patch release needs-documentation This issue or change requires additional documentation
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Qix- @mitant @davidekete