Use pagy_prev_url with trim extra?

[marckohlbrugge]

Even with the trim extra enabled, pagy_prev_url can still return ?page=1.

Is there a way to trim page=1 with pagy_prev_url ?

• https://ddnexus.github.io/pagy/docs/extras/trim/#trim-extra

Relevant code:

pagy/gem/lib/pagy/extras/trim.rb

Lines 4 to 29 in d70e443

	class Pagy # :nodoc:
	DEFAULT[:trim_extra] = true # extra enabled by default
	# Remove the page=1 param from the first page link
	module TrimExtra
	# Override the original pagy_anchor.
	# Call the pagy_trim method for page 1 if the trim_extra is enabled
	def pagy_anchor(pagy, **_)
	a_proc = super
	return a_proc unless pagy.vars[:trim_extra]
	lambda do |page, text = pagy.label_for(page), **opts|
	a = +a_proc.(page, text, **opts)
	return a unless page.to_s == '1'
	pagy_trim(pagy, a) # in method for isolated testing
	end
	end
	# Remove the :page_param param from the first page anchor
	def pagy_trim(pagy, a)
	a.sub!(/[?&]#{pagy.vars[:page_param]}=1\b(?!&)|\b#{pagy.vars[:page_param]}=1&/, '')
	end
	end
	Frontend.prepend TrimExtra
	end

pagy/gem/lib/pagy/extras/pagy.rb

Lines 49 to 52 in d70e443

	# Return the previous page URL string or nil
	def pagy_prev_url(pagy, **vars)
	pagy_url_for(pagy, pagy.prev, **vars) if pagy.prev
	end

[ddnexus]

Hi @marckohlbrugge,
the trim has always been very problematic. Pagy is just the wrong place to put the trim logic. Indeed, we will discontinue the extra in the upcoming v10.

From the Changelog of v10:

##### `trim` (discontinued feature)

- It was mostly useless and half-backed, causing a lot of complications in the ruby and javascript code for no real benefit.
- Use a proper way to address your requirement, like using URL rewriting at the HTTP server level.

We understand that the discontinuation of the trim extra may be disruptive, and we sincerely apologize for any problems this causes. We appreciate your understanding.

[marckohlbrugge]

Thank you for the quick reply!

I understand. I will make my own solution. Shouldn't be too hard.

Thank you for all your work on this gem 🙏