Fix reporting of errors on Windows

Tyriar · Tyriar · commit e9116e16f880 · 2017-07-09T12:58:36.000-07:00
When winpty exceptions occurred they were silently failing due to marshal not being initialized. Part of chjj#102 Part of chjj#103
diff --git a/src/win/pty.cc b/src/win/pty.cc
@@ -256,15 +256,14 @@ static NAN_METHOD(PtyStartProcess) {
     std::string conoutPipeNameStr(conoutPipeNameWStr.begin(), conoutPipeNameWStr.end());
     marshal->Set(Nan::New<v8::String>("conout").ToLocalChecked(), Nan::New<v8::String>(conoutPipeNameStr).ToLocalChecked());
   }
+  info.GetReturnValue().Set(marshal);
 
   goto cleanup;
 
 cleanup:
   delete filename;
   delete cmdline;
   delete cwd;
-
-  info.GetReturnValue().Set(marshal);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -256,15 +256,14 @@ static NAN_METHOD(PtyStartProcess) {`
`256`	`256`	`std::string conoutPipeNameStr(conoutPipeNameWStr.begin(), conoutPipeNameWStr.end());`
`257`	`257`	`marshal->Set(Nan::New<v8::String>("conout").ToLocalChecked(), Nan::New<v8::String>(conoutPipeNameStr).ToLocalChecked());`
`258`	`258`	`}`
	`259`	`+ info.GetReturnValue().Set(marshal);`
`259`	`260`
`260`	`261`	`goto cleanup;`
`261`	`262`
`262`	`263`	`cleanup:`
`263`	`264`	`delete filename;`
`264`	`265`	`delete cmdline;`
`265`	`266`	`delete cwd;`
`266`		`-`
`267`		`- info.GetReturnValue().Set(marshal);`
`268`	`267`	`}`
`269`	`268`
`270`	`269`	`/*`