Skip to content

Commit a96d1c6

Browse files
authored
Remove custom SL SDK implementation (#83)
Overriding the SL SDK was necessary to patch a small fix. Now that the fix is in the underlying SDK, we no longer need to patch it.
1 parent d113804 commit a96d1c6

File tree

9 files changed

+6
-224
lines changed

9 files changed

+6
-224
lines changed

evals/semantic_layer/test_eval_semantic_layer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from typing import Any
33

44
import pytest
5+
from dbtsl.api.shared.query_params import GroupByParam
56
from openai import OpenAI
67
from openai.types.responses import (
78
FunctionToolParam,
@@ -15,7 +16,6 @@
1516
from dbt_mcp.config.config import load_config
1617
from dbt_mcp.mcp.server import dbt_mcp
1718
from dbt_mcp.semantic_layer.client import get_semantic_layer_fetcher
18-
from dbt_mcp.semantic_layer.sdk.query_params import GroupByParam
1919
from dbt_mcp.semantic_layer.types import OrderByParam, QueryMetricsSuccess
2020

2121
LLM_MODEL = "gpt-4o-mini"

src/dbt_mcp/semantic_layer/client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
from functools import cache
22

3-
from dbtsl.api.shared.query_params import OrderByGroupBy
3+
from dbtsl.api.shared.query_params import GroupByParam, OrderByGroupBy
4+
from dbtsl.client.sync import SyncSemanticLayerClient
45
from dbtsl.error import QueryFailedError
56

67
from dbt_mcp.config.config import Config
78
from dbt_mcp.semantic_layer.gql.gql import GRAPHQL_QUERIES
89
from dbt_mcp.semantic_layer.gql.gql_request import ConnAttr, submit_request
910
from dbt_mcp.semantic_layer.levenshtein import get_misspellings
10-
from dbt_mcp.semantic_layer.sdk.query_params import GroupByParam
11-
from dbt_mcp.semantic_layer.sdk.sync_sl_client import SyncSemanticLayerClient
1211
from dbt_mcp.semantic_layer.types import (
1312
DimensionToolResponse,
1413
EntityToolResponse,

src/dbt_mcp/semantic_layer/sdk/adbc_protocol.py

Lines changed: 0 additions & 51 deletions
This file was deleted.

src/dbt_mcp/semantic_layer/sdk/base_adbc_client.py

Lines changed: 0 additions & 10 deletions
This file was deleted.

src/dbt_mcp/semantic_layer/sdk/query_params.py

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/dbt_mcp/semantic_layer/sdk/sync_adbc_client.py

Lines changed: 0 additions & 80 deletions
This file was deleted.

src/dbt_mcp/semantic_layer/sdk/sync_sl_client.py

Lines changed: 0 additions & 60 deletions
This file was deleted.

src/dbt_mcp/semantic_layer/tools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import logging
22
from time import time
33

4+
from dbtsl.api.shared.query_params import GroupByParam
45
from mcp.server.fastmcp import FastMCP
56

67
from dbt_mcp.config.config import Config
78
from dbt_mcp.prompts.prompts import get_prompt
89
from dbt_mcp.semantic_layer.client import get_semantic_layer_fetcher
9-
from dbt_mcp.semantic_layer.sdk.query_params import GroupByParam
1010
from dbt_mcp.semantic_layer.types import (
1111
DimensionToolResponse,
1212
EntityToolResponse,

tests/integration/semantic_layer/test_semantic_layer.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
from dbtsl.api.shared.query_params import GroupByParam, GroupByType
2+
13
from dbt_mcp.config.config import load_config
24
from dbt_mcp.semantic_layer.client import get_semantic_layer_fetcher
3-
from dbt_mcp.semantic_layer.sdk.query_params import GroupByParam, GroupByType
45
from dbt_mcp.semantic_layer.types import OrderByParam
56

67
config = load_config()

0 commit comments

Comments
 (0)