Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Bigquery job labels missing when using CopyJobConfig in copy_bq_table #774

Open
2 tasks done
Alex-Krykun opened this issue Jan 30, 2025 · 2 comments · May be fixed by #795
Open
2 tasks done

[Feature] Bigquery job labels missing when using CopyJobConfig in copy_bq_table #774

Alex-Krykun opened this issue Jan 30, 2025 · 2 comments · May be fixed by #795
Labels
pkg:dbt-bigquery Issue affects dbt-bigquery type:enhancement New feature request

Comments

@Alex-Krykun
Copy link

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When DBT copies temp tables to the destination table, BQ Jobs missing labels.

Expected Behavior

Add job_labels for copying table as well as for other operations.

Steps To Reproduce

Run any dbt module that involves a copy table, and check in the BQ Console that the job doesn't have any custom labels.

Relevant log output

Please, check https://github.com/dbt-labs/dbt-bigquery/blob/main/dbt/adapters/bigquery/connections.py#L443 for CopyJobConfig we can pass labels (IMHO).

Environment

- OS:MacOS Sequoia 15.3
- Python:3.10
- dbt-core: 1.9.0
- dbt-bigquery: 1.9.0

Additional Context

No response

@Alex-Krykun
Copy link
Author

I created a draft PR: dbt-labs/dbt-bigquery#1464, as changes included all methods that have already been covered by unit tests, I am not sure if I need to add additional checks, and if yes where exactly.

@amychen1776 amychen1776 transferred this issue from dbt-labs/dbt-bigquery Feb 4, 2025
@Alex-Krykun Alex-Krykun linked a pull request Feb 5, 2025 that will close this issue
4 tasks
@Alex-Krykun
Copy link
Author

As a possible solution, please, consider my PR #795
Thank you!

@amychen1776 amychen1776 added the triage:product In Product's queue label Feb 6, 2025
@amychen1776 amychen1776 changed the title [Bug] Bigquery job labels missing when using CopyJobConfig in copy_bq_table [Feature] Bigquery job labels missing when using CopyJobConfig in copy_bq_table Feb 7, 2025
@amychen1776 amychen1776 added type:enhancement New feature request pkg:dbt-bigquery Issue affects dbt-bigquery and removed triage:product In Product's queue labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:dbt-bigquery Issue affects dbt-bigquery type:enhancement New feature request
Projects
None yet
2 participants