From f02d97ec9b66336ef536e34c728f5c94bab77745 Mon Sep 17 00:00:00 2001 From: Colin Date: Sun, 9 Feb 2025 13:25:27 -0800 Subject: [PATCH] fix formatting and improve hatch --- dbt-snowflake/hatch.toml | 7 ++++--- .../src/dbt/adapters/snowflake/catalog.py | 7 +++++-- .../tests/unit/test_managed_iceberg_catalog.py | 15 ++++++++------- 3 files changed, 17 insertions(+), 12 deletions(-) diff --git a/dbt-snowflake/hatch.toml b/dbt-snowflake/hatch.toml index 3007057fb..6feef8690 100644 --- a/dbt-snowflake/hatch.toml +++ b/dbt-snowflake/hatch.toml @@ -43,9 +43,10 @@ docker-dev = [ # pre-install commands here and post-install commands in the matrix can be moved # to the dependencies section pre-install-commands = [ - "pip install -e ../dbt-adapter", - "pip install -e ../dbt-core/core", - ] + "pip install -e ../dbt-adapters", + "pip install -e ../dbt-tests-adapter", + "pip install -e ../../dbt-core/core", +] [envs.build] detached = true diff --git a/dbt-snowflake/src/dbt/adapters/snowflake/catalog.py b/dbt-snowflake/src/dbt/adapters/snowflake/catalog.py index b965d3bf7..d27a51a57 100644 --- a/dbt-snowflake/src/dbt/adapters/snowflake/catalog.py +++ b/dbt-snowflake/src/dbt/adapters/snowflake/catalog.py @@ -11,10 +11,11 @@ _SNOWFLAKE_BOOLEAN_VALUES = ["TRUE", "FALSE"] + class SnowflakeManagedIcebergCatalogIntegration(CatalogIntegration): catalog_type = CatalogIntegrationType.managed auto_refresh: Optional[str] = None - replace_invalid_characters: Optional[str] = None + replace_invalid_characters: Optional[str] = None def _handle_adapter_properties(self, adapter_properties: Optional[Dict]) -> None: if adapter_properties: @@ -24,7 +25,9 @@ def _handle_adapter_properties(self, adapter_properties: Optional[Dict]) -> None self.auto_refresh = auto_refresh if replace_invalid_characters := adapter_properties.get("replace_invalid_characters"): if replace_invalid_characters not in _SNOWFLAKE_BOOLEAN_VALUES: - raise DbtValidationError(f"Invalid replace_invalid_characters value: {replace_invalid_characters}") + raise DbtValidationError( + f"Invalid replace_invalid_characters value: {replace_invalid_characters}" + ) self.replace_invalid_characters = replace_invalid_characters def render_ddl_predicates(self, relation: BaseRelation, config: RelationConfig) -> str: diff --git a/dbt-snowflake/tests/unit/test_managed_iceberg_catalog.py b/dbt-snowflake/tests/unit/test_managed_iceberg_catalog.py index 68a305d44..029da74a4 100644 --- a/dbt-snowflake/tests/unit/test_managed_iceberg_catalog.py +++ b/dbt-snowflake/tests/unit/test_managed_iceberg_catalog.py @@ -137,11 +137,12 @@ def test_managed_iceberg_catalog_with_invalid_properties(): with pytest.raises(DbtValidationError): SnowflakeManagedIcebergCatalogIntegration( CatalogIntegrationConfig( - catalog_name="my_catalog", - integration_name="my_integration", - table_format="iceberg", - catalog_type="managed", - external_volume="s3_iceberg_snow", - namespace="my_namespace", - adapter_properties={"auto_refresh": "INVALID"}) + catalog_name="my_catalog", + integration_name="my_integration", + table_format="iceberg", + catalog_type="managed", + external_volume="s3_iceberg_snow", + namespace="my_namespace", + adapter_properties={"auto_refresh": "INVALID"}, + ) )