Skip to content

Commit 9616a23

Browse files
authored
refactor: testing (#14)
* refactor: disabled some html validation aspects either because of example related or specific usage * refactor: we don't need to declare this role as it's set implicitly, compare to e.g. developer.mozilla.org/en-US/docs/Web/HTML/Element/footer * refactor: we don't need to declare this role as it's set implicitly, compare to e.g. developer.mozilla.org/en-US/docs/Web/HTML/Element/main * refactor: disabled the correct code line * refactor: disabled html validation aspect * refactor: consistent quotes * refactor: consistent quotes * refactor: in case we don't have a description, we won't need the aria-describedby attribute * chore: providing another default * refactor: set a default for the buttontype * refactor: restructured the sample page to reflect a correct headline structure * refactor: ignore those headline structures on HTML validation as they are too hard to influence in sample pages * refactor: we don't need to declare this role as it's set implicitly, compare to e.g. developer.mozilla.org/en-US/docs/Web/HTML/Element/nav * refactor: ignore those headline structures on HTML validation as they are too hard to influence in sample pages * refactor: ignore this headline structures on HTML validation as a headline of type 2 is perfectly fine in this new context * refactor: there shouldn't be more than one main landmark elements * refactor: ignore those headline structures on HTML validation as they are too hard to influence in sample pages * refactor: details tag nesting in p not allowed Element <details> is not permitted as content in <p> * refactor: corrected that attributes naming * refactor: ignore this headline structures on HTML validation as they are too hard to influence in sample pages * refactor: adapted the HTML validation rules to our needs * refactor: optimized the test and lint scripts reordered, renamed and added npx * chore: removed leftover * refactor: optimized list of test urls for accessibility * refactor: optimized test scripts and added new dependency for running server and tests in parallel * refactor: disabling stylelint rules for specific code parts * refactor: stylelint feedback * refactor: stylelint feedback * refactor: html validate feedback * test: we don't want to test for self-closing tags * feat: suggesting html validate as well as VS Code extension * refactor(test): using the smaller markup-only files for HTML testing * chore: regenerated package-lock.json * chore: prettier optimization * refactor: running prettier for linting * chore: we need the SCSS function here * chore: we need to provide different ID values here
1 parent cbc3aae commit 9616a23

40 files changed

+727
-542
lines changed

.github/workflows/01-test.yml

+3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ jobs:
1414
- name: 🔄 Init Cache
1515
uses: ./.github/actions/npm-cache
1616

17+
- name: ⚡ Run Lint
18+
run: npm run lint
19+
1720
- name: ⚡ Run Test
1821
run: npm run test
1922

.htmlvalidate.json

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
{
22
"extends": ["html-validate:document", "html-validate:recommended"],
3-
43
"rules": {
5-
"void-style": ["warn", { "style": "selfclosing" }],
6-
"require-sri": ["error", { "target": "crossorigin" }]
4+
"require-sri": ["error", { "target": "crossorigin" }],
5+
"no-trailing-whitespace": ["off"],
6+
"doctype-style": ["off"],
7+
"element-name": ["error", { "whitelist": ["dialog"] }],
8+
"missing-doctype": ["off"]
79
}
810
}

.pa11yci

+25-192
Large diffs are not rendered by default.

.prettierignore

+1
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ dependencyGraph.json
1212
source/js/*.min.js*
1313
package-lock.json
1414
*.hbs
15+
out/

.stylelintrc.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
"stylelint-config-prettier"
55
],
66
"rules": {
7+
"order/properties-alphabetical-order": null,
8+
"scss/operator-no-newline-after": null,
9+
"declaration-empty-line-before": null,
710
"selector-no-qualifying-type": null,
811
"selector-class-pattern": null,
912
"scss/dollar-variable-pattern": null,
@@ -14,6 +17,7 @@
1417
"declaration-property-value-disallowed-list": null,
1518
"scss/percent-placeholder-pattern": null,
1619
"scss/at-mixin-pattern": null,
17-
"order/properties-alphabetical-order": null
20+
"order/properties-alphabetical-order": null,
21+
"scss/at-import-partial-extension": null
1822
}
1923
}

.vscode/extensions.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"recommendations": [
33
"editorconfig.editorconfig",
44
"henrynguyen5-vsc.vsc-nvm",
5-
"streetsidesoftware.code-spell-checker"
5+
"streetsidesoftware.code-spell-checker",
6+
"html-validate.vscode-html-validate"
67
]
78
}

0 commit comments

Comments
 (0)