forked from CaioBrighenti/nba-models
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathMVPModels.R
More file actions
442 lines (390 loc) · 16.3 KB
/
Copy pathMVPModels.R
File metadata and controls
442 lines (390 loc) · 16.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
## HYPERPARAMETERS
SHORT_CUTOFF <- 0.75
YEAR_START<-2000
YEAR_END<-2018
NORM <- FALSE
#######################################################
############### PROCESS BBALLREF DATA #################
#######################################################
#source("loadData.R")
#LOAD STANDINGS DATA
dat_std<-loadStandings(YEAR_START,2019)
# LOAD MVP DATA
dat_mvp<-loadMVP(YEAR_START,YEAR_END,dat_std)
# LOAD TOTAL PLAYER STATS
dat_totals<-loadTotals(YEAR_START,YEAR_END,dat_mvp,normalize=NORM)
# LOAD PERGAME PLAYER STATS
dat_pergame<-loadPerGame(YEAR_START,YEAR_END,dat_mvp,normalize=NORM)
# LOAD ADVANCED PLAYER STATS
dat_adv<-loadAdvanced(YEAR_START,YEAR_END,dat_mvp,normalize=NORM)
# WRITE TO CSVs
write.csv(dat_std,file = "full-data/standings.csv",row.names=FALSE)
write.csv(dat_mvp,file = "full-data/mvp.csv",row.names=FALSE)
write.csv(dat_totals,file = "full-data/totals.csv",row.names=FALSE)
write.csv(dat_pergame,file = "full-data/pergame.csv",row.names=FALSE)
write.csv(dat_adv,file = "full-data/advanced.csv",row.names=FALSE)
#######################################################
################## LOAD MERGED CSVs ###################
#######################################################
# LOAD STANDINGS DATA
dat_std<-read.csv("full-data/standings.csv",header=TRUE)
# LOAD MVP DATA
dat_mvp<-read.csv("full-data/mvp.csv",header=TRUE)
# LOAD TOTAL PLAYER STATS
dat_totals<-read.csv("full-data/totals.csv",header=TRUE)
# LOAD PERGAME PLAYER STATS
dat_pergame<-read.csv("full-data/pergame.csv",header=TRUE)
# LOAD PERGAME PLAYER STATS
dat_adv<-read.csv("full-data/advanced.csv",header=TRUE)
## total prelim stats
# library("dplyr")
# library("corrplot")
# par(mfrow=c(1,1))
# dtot_numeric<-select_if(dat_totals, is.numeric)
# corrplot(cor(dtot_numeric))
#
# ## MVP prelim stats
# dmvp_numeric<-select_if(dat_mvp, is.numeric)
# corrplot(cor(dmvp_numeric))
#
# ## advanced prelim stats
# dadv_numeric<-select_if(dat_adv, is.numeric)
# corrplot(cor(dadv_numeric,use="complete.obs"))
# ## visualize
# par(mfrow=c(1,2))
# ### VORP VS PER
# plot(dat_adv$VORP, dat_adv$PER)
# dat_adv_mvps <- dat_adv[which(dat_adv$MVP==TRUE),]
# points(dat_adv_mvps$VORP,dat_adv_mvps$PER,pch=19,col="red")
# ### WS VS BPM
# plot(dat_adv$WS, dat_adv$BPM)
# dat_adv_mvps <- dat_adv[which(dat_adv$MVP==TRUE),]
# points(dat_adv_mvps$WS,dat_adv_mvps$BPM,pch=19,col="red")
#######################################################
################# TOTAL STATS MODELS ##################
#######################################################
## fit shortlist model
dat_totals$Shortlist<-dat_totals$Share!=0
tot.short.mod <- glm(Shortlist~G+MP+X3P+DRB+AST+
BLK+TOV+PF+PTS+Team.Wins,data=dat_totals,family = binomial(link = "logit"))
## grab shortlist
tot.shortlist<-dat_totals[which(predict(tot.short.mod,type="response")>SHORT_CUTOFF),]
## fit linear
tot.lm <- lm(First~G+X3P+DRB+AST+BLK+PF+PTS+Team.Wins,data=tot.shortlist)
## linear pred
tot.lm.pred<-predMVPs(tot.shortlist,tot.lm)
tot.lm.acc<-calcAccuracy(tot.lm.pred,FALSE)
## fit logit
tot.log <- glm(MVP~G+X3P+DRB+AST+BLK+PF+PTS+Team.Wins,data=tot.shortlist,family = binomial(link = "logit"))
## logit pred
tot.log.pred<-predMVPs(tot.shortlist,tot.log)
tot.log.acc<-calcAccuracy(tot.log.pred,FALSE)
## LASSO
library(glmnet)
x = model.matrix(First~as.factor(Pos)+Age+G+GS+MP+FG+FGA+FG.+X3P+X3PA+X3P.+X2P+X2PA+X2P.+
eFG.+FT+FTA+FT.+ORB+DRB+TRB+AST+STL+BLK+TOV+PF+PTS+Team.Wins,data=tot.shortlist)
y = tot.shortlist$First
tot.cv.out <- cv.glmnet(x,y,alpha=1)
lasso.coef=predict(tot.cv.out,type="coefficients",s=tot.cv.out$lambda.min)
## fit poly
tot.poly <- lm(First~poly(G,3)+poly(X3P,3)+poly(DRB,3)+poly(AST,3)+poly(BLK,3)+poly(PF,3)+
poly(PTS,3)+poly(Team.Wins,3),data=tot.shortlist)
## poly pred
tot.poly.pred<-predMVPs(tot.shortlist,tot.poly)
tot.poly.acc<-calcAccuracy(tot.poly.pred,FALSE)
#######################################################
############### PERGAME STATS MODELS ##################
#######################################################
## fit shortlist model
dat_pergame$Shortlist<-dat_pergame$Share!=0
pg.short.mod <- glm(Shortlist~Age+G+GS+MP+FG+FG.+X3P+X3P.+X2P.+FT.+ORB+DRB+AST+STL+BLK+TOV+PF+PTS+Team.Wins,
data=dat_pergame,family = binomial(link = "logit"))
## grab shortlist
pg.shortlist<-dat_pergame[which(predict(pg.short.mod,type="response")>SHORT_CUTOFF),]
## fit linear
pg.lm <- lm(First~Age+G+GS+MP+FG+FG.+X3P+X3P.+X2P.+FT.+ORB+DRB+AST+STL+BLK+TOV+PF+PTS+Team.Wins
,data=pg.shortlist)
## linear pred
pg.lm.pred<-predMVPs(pg.shortlist,pg.lm)
pg.lm.acc<-calcAccuracy(pg.lm.pred,FALSE)
## fit logit
pg.log <- glm(MVP~Age+G+GS+MP+FG+FG.+X3P+X3P.+X2P.+FT.+ORB+DRB+AST+STL+BLK+TOV+PF+PTS+Team.Wins
,data=pg.shortlist,family = binomial(link = "logit"))
## logit pred
pg.log.pred<-predMVPs(pg.shortlist,pg.log)
pg.log.acc<-calcAccuracy(pg.log.pred,FALSE)
## fit poly
pg.poly <- lm(First~poly(Age,3)+poly(G,3)+poly(GS,3)+poly(MP,3)+poly(FG,3)+poly(FG.,3)+poly(X3P,3)+poly(X3P.,3)+poly(X2P.,3)+
poly(FT.,3)+poly(ORB,3)+poly(DRB,3)+poly(AST,3)+poly(STL,3)+poly(BLK,3)+poly(TOV,3)+poly(PF,3)+
poly(PTS,3)+poly(Team.Wins,3),data=pg.shortlist)
## poly pred
pg.poly.pred<-predMVPs(pg.shortlist,pg.poly)
pg.poly.acc<-calcAccuracy(pg.poly.pred,FALSE)
#######################################################
################ ADVANCED STATS MODELS ################
#######################################################
## fit shortlist model
dat_adv$Shortlist<-dat_adv$Share!=0
adv.short.mod <- glm(Shortlist~G+MP+PER+TS.+X3PAr+FTr+ORB.+DRB.+TRB.+AST.+STL.+BLK.+
TOV.+USG.+OWS+DWS+WS+WS.48+OBPM+DBPM+BPM+VORP+Team.Wins,
data=dat_adv,family = binomial(link = "logit"))
## grab shortlist
adv.shortlist<-dat_adv[which(predict(adv.short.mod,type="response")>SHORT_CUTOFF),]
## fit linear
adv.lm <- lm(First~G+PER+TS.+X3PAr+FTr+TRB.+AST.+STL.+BLK.+
TOV.+USG.+WS+BPM+VORP+Team.Wins,
data=adv.shortlist)
## linear pred
adv.lm.pred<-predMVPs(adv.shortlist,adv.lm)
adv.lm.acc<-calcAccuracy(adv.lm.pred,FALSE)
## fit logit
adv.log <- glm(MVP~PER+TS.+X3PAr+FTr+TRB.+AST.+STL.+BLK.+
TOV.+USG.+WS+BPM+VORP+Team.Wins
,data=adv.shortlist,family = binomial(link = "logit"))
## logit pred
adv.log.pred<-predMVPs(adv.shortlist,adv.log)
adv.log.acc<-calcAccuracy(adv.log.pred,FALSE)
## LASSO
#library(glmnet)
x = model.matrix(First~G+MP+PER+TS.+X3PAr+FTr+ORB.+DRB.+TRB.+AST.+STL.+BLK.+
TOV.+USG.+OWS+DWS+WS+WS.48+OBPM+DBPM+BPM+VORP+Team.Wins
,data=adv.shortlist)
y = adv.shortlist$First
adv.cv.out <- cv.glmnet(x,y,alpha=1)
adv.lasso.coef=predict(adv.cv.out,type="coefficients",s=adv.cv.out$lambda.min)
## fit poly
adv.poly <- lm(First~poly(PER,3)+poly(TS.,3)+poly(X3PAr,3)+poly(FTr,3)+poly(TRB.,3)+poly(AST.,3)+poly(STL.,3)+poly(BLK.,3)+
poly(TOV.,3)+poly(USG.,3)+poly(WS,3)+poly(BPM,3)+poly(VORP,3)+poly(Team.Wins,3),
data=adv.shortlist)
## poly pred
adv.poly.pred<-predMVPs(adv.shortlist,adv.poly)
adv.poly.acc<-calcAccuracy(adv.poly.pred,FALSE)
#######################################################
##################### MERGED DATA ####################
#######################################################
## merge data
dat_merge <- dat_totals
adv_subset <- dat_adv[,c(2,3,12,13,14,15,18,19,20,21,22,23,26,30,31)]
dat_merge <- merge(dat_merge,adv_subset,by=c("Player","Season"))
## grab shortlist
merge.shortlist<-dat_merge[which(predict(tot.short.mod,newdata = dat_merge,type="response")>SHORT_CUTOFF),]
## predict for each model
merge.tot.pred<-predict(tot.log,newdata=merge.shortlist,type="response")
merge.adv.pred<-predict(adv.log,newdata=merge.shortlist,type="response")
merge.pred <- (merge.tot.pred + merge.adv.pred) / 2
## select MVPS
### create empty MVPs dataframe
merge.mvps<-merge.shortlist[0,]
for (year in levels(as.factor(merge.shortlist$Season))) {
dat_temp<-merge.shortlist[which(merge.shortlist$Season==year),]
temp_preds<-merge.pred[which(merge.shortlist$Season==year)]
mvp<-dat_temp[which(temp_preds==max(temp_preds)),]
merge.mvps<-data.frame(rbind(as.matrix(merge.mvps), as.matrix(mvp)))
}
merge.acc<-calcAccuracy(merge.mvps,FALSE)
## fit linear
merge.lm <- lm(First~G+PER+TS.+X3PAr+FTr+TRB.+AST.+STL.+BLK.+
TOV.+USG.+WS+BPM+VORP+Team.Wins+X3P+DRB+
AST+BLK+PF+PTS,
data=merge.shortlist)
## linear pred
merge.lm.pred<-predMVPs(merge.shortlist,merge.lm)
merge.lm.acc<-calcAccuracy(merge.lm.pred,FALSE)
## fit logit
merge.log <- glm(MVP~G+PER+TS.+X3PAr+FTr+TRB.+AST.+STL.+BLK.+
TOV.+USG.+WS+BPM+VORP+Team.Wins+X3P+DRB+
AST+BLK+PF+PTS,
data=merge.shortlist,family = binomial(link = "logit"))
## logit pred
merge.log.pred<-predMVPs(merge.shortlist,merge.log)
merge.log.acc<-calcAccuracy(merge.log.pred,FALSE)
## fit poly
merge.poly <- lm(First~poly(G,3)+poly(PER,3)+poly(TS.,3)+poly(X3PAr,3)+poly(FTr,3)+poly(TRB.,3)+
poly(AST.,3)+poly(STL.,3)+poly(BLK.,3)+poly(TOV.,3)+poly(USG.,3)+poly(WS,3)+
poly(BPM,3)+poly(VORP,3)+poly(Team.Wins,3)+poly(PER,3)+poly(TS.,3)+poly(X3PAr,3)+
poly(FTr,3)+poly(TRB.,3)+poly(AST.,3)+poly(STL.,3)+poly(BLK.,3)+poly(TOV.,3)+
poly(USG.,3)+poly(WS,3)+poly(BPM,3)+poly(VORP,3),
data=merge.shortlist)
## poly pred
merge.poly.pred<-predMVPs(merge.shortlist,merge.poly)
merge.poly.acc<-calcAccuracy(merge.poly.pred,FALSE)
#######################################################
################## CROSS VALIDATION ###################
#######################################################
# total data
tlm.cv.acc<-accuracyCV(tot.shortlist,tot.lm)
tlog.cv.acc<-accuracyCV(tot.shortlist,tot.log)
tpoly.cv.acc<-accuracyCV(tot.shortlist,tot.poly)
# per game data
plm.cv.acc<-accuracyCV(pg.shortlist,pg.lm)
plog.cv.acc<-accuracyCV(pg.shortlist,pg.log)
ppoly.cv.acc<-accuracyCV(pg.shortlist,pg.poly)
# advanced data
alm.cv.acc<-accuracyCV(adv.shortlist,adv.lm)
alog.cv.acc<-accuracyCV(adv.shortlist,adv.log)
apoly.cv.acc<-accuracyCV(adv.shortlist,adv.poly)
# merged data
mlm.cv.acc<-accuracyCV(merge.shortlist,merge.lm)
mlog.cv.acc<-accuracyCV(merge.shortlist,merge.log)
mpoly.cv.acc<-accuracyCV(merge.shortlist,merge.poly)
## aggregate model
agglm.cv.acc<-aggregateCV(merge.shortlist,tot.lm,pg.lm)
agglog.cv.acc<-aggregateCV(merge.shortlist,tot.log,pg.log)
aggpoly.cv.acc<-aggregateCV(merge.shortlist,tot.poly,pg.poly)
#######################################################
#################### SUMMARY PLOTS ####################
#######################################################
accs <- data.frame(Data=c("dat_tot","dat_pergame","dat_adv","dat_merge"),
Linear=c(tot.lm.acc,pg.lm.acc,adv.lm.acc,merge.lm.acc),
Logistic=c(tot.log.acc,pg.log.acc,adv.log.acc,merge.log.acc),
Cubic=c(tot.poly.acc,pg.poly.acc,adv.poly.acc,merge.poly.acc),
LOOCV.lm=c(tlm.cv.acc,plm.cv.acc,alm.cv.acc,mlm.cv.acc),
LOOCV.log=c(tlog.cv.acc,plog.cv.acc,alog.cv.acc,mlog.cv.acc),
LOOCV.poly=c(tpoly.cv.acc,ppoly.cv.acc,apoly.cv.acc,mpoly.cv.acc))
par(mfrow=c(1,1))
#library(RColorBrewer)
library(viridis)
vir=viridis(6)
xx=barplot(c(accs$Linear,accs$LOOCV.lm,accs$Logistic,accs$LOOCV.log,accs$Cubic,accs$LOOCV.poly),
names.arg=rep(accs$Data,times=6),
ylim=c(0,1),
las=2,
col=c(rep(vir[1],4),rep(vir[2],4),rep(vir[3],4),rep(vir[4],4),rep(vir[5],4),rep(vir[6],4)),
ylab="Accuracy",
main=paste("Model Accuracies -",YEAR_START,"-",YEAR_END)
)
if(NORM){
str<-"Normalized -"
} else {
str<-"Unnormalized -"
}
mtext(paste(str,"Shortlist",SHORT_CUTOFF,"cutoff"))
text(x=xx,
y=c(accs$Linear,accs$LOOCV.lm,accs$Logistic,accs$LOOCV.log,accs$Cubic,accs$LOOCV.poly),
label=round(c(accs$Linear,accs$LOOCV.lm,accs$Logistic,accs$LOOCV.log,accs$Cubic,accs$LOOCV.poly),digits=3),
pos=3
)
legend("bottomright",
c("Linear","Linear LOOCV","Logistic","Logistic LOOCV","Cubic","Cubic LOOCV"),
fill=vir,
cex=0.8
)
#######################################################
################# PREDICT FOR 2019 ##################
#######################################################
# LOAD 2019 STATS
dat_2019_tot<-loadCurrent(normalize = NORM)
dat_2019_adv<-loadCurrentAdv(normalize = NORM)
# predict shortlist
shortlist.pred<-predict(tot.short.mod,dat_2019_tot)
shortlist_2019<-dat_2019_tot[order(-shortlist.pred),]
shortlist_2019<-shortlist_2019[1:10,]
# predict winner - with shortlist
pred<-predict(tot.lm,shortlist_2019,type="response")
shortlist_2019$Pred<-pred
shortlist_2019<-shortlist_2019[order(-shortlist_2019$Pred),]
# turn shortlist predictions into percentages
shortlist_2019$Pct<-shortlist_2019$Pred-min(shortlist_2019$Pred)
shortlist_2019$Pct<-(shortlist_2019$Pct/sum(shortlist_2019$Pct))*100
## write predictions to csv
pred_dat<-data.frame(Player=shortlist_2019$Player,Pct=shortlist_2019$Pct)
write.csv(pred_dat, file = "html/2019Pred.csv",row.names=FALSE)
# mod refining ideas
## lockout seasons
## minimum games
## reverse recency bias
## partial seasons
## add advanced stats
## minimum advanced stats (PER)
## post all-star game numbers
#######################################################
################## INVERSE RECENCY ####################
#######################################################
#######################################################
################# HELPER FUNCTIONS ####################
#######################################################
predMVPs <- function(param.dat,param.mod,lasso=FALSE,bestlam=0){
# make predictions
if (lasso == TRUE) {
## lasso case
predict(param.mod,s=bestlam,newx=param.dat)
} else {
## linear/logistic cases
pred<-predict(param.mod,newdata=param.dat,type="response")
}
# create empty MVPs dataframe
mvps<-param.dat[0,]
for (year in levels(as.factor(param.dat$Season))) {
dat_temp<-param.dat[which(param.dat$Season==year),]
temp_preds<-pred[which(param.dat$Season==year)]
mvp<-dat_temp[which(temp_preds==max(temp_preds)),]
mvps<-data.frame(rbind(as.matrix(mvps), as.matrix(mvp)))
}
return(mvps)
}
# $Rank versus $MVP is hacky right now, needs better system
calcAccuracy <- function(mvps,ranks) {
if (ranks){
errs<-mvps[which(mvps$Rank!=1),]
} else {
errs<-mvps[which(mvps$MVP==FALSE),]
}
print(errs)
return(1-(dim(errs)[1]/dim(mvps)[1]))
}
accuracyCV <- function(param.dat,param.mod){
# extract formula from model
mvps<-param.dat[0,]
for (year in min(param.dat$Season):max(param.dat$Season)) {
# leave out one year
test <- param.dat[which(param.dat$Season == year),]
train <- param.dat[which(param.dat$Season != year),]
# train model on remaining
## fit model
if (param.mod$call[1]=="glm()"){
## logistic
cv <- glm(param.mod$call[2],data=train,family = binomial(link = "logit"))
} else {
## linear
cv <- lm(param.mod$call[2],data=train)
}
## linear pred
cv.pred<-predict(cv,newdata=test,type="response")
cv.mvp<-test[which(cv.pred == max(cv.pred)),]
mvps <- data.frame(rbind(as.matrix(mvps), as.matrix(cv.mvp)))
# test on leaveout
}
return(calcAccuracy(mvps,FALSE))
}
aggregateCV <- function(param.dat,mod1,mod2){
mvps<-param.dat[0,]
for (year in min(param.dat$Season):max(param.dat$Season)) {
# leave out one year
test <- param.dat[which(param.dat$Season == year),]
train <- param.dat[which(param.dat$Season != year),]
# train model on remaining
### FIRST MODEL
if (mod1$call[1]=="glm()"){
## logistic
cv1 <- glm(mod1$call[2],data=train,family = binomial(link = "logit"))
} else {
## linear
cv1 <- lm(mod1$call[2],data=train)
}
### SECOND MODEL
if (mod2$call[1]=="glm()"){
## logistic
cv2 <- glm(mod2$call[2],data=train,family = binomial(link = "logit"))
} else {
## linear
cv2 <- lm(mod2$call[2],data=train)
}
## predict for each model
cv1.pred<-predict(cv1,newdata=test,type="response")
cv2.pred<-predict(cv2,newdata=test,type="response")
cv.pred <- (cv1.pred + cv2.pred) / 2
cv.mvp<-test[which(cv.pred == max(cv.pred)),]
mvps <- data.frame(rbind(as.matrix(mvps), as.matrix(cv.mvp)))
}
return(calcAccuracy(mvps,FALSE))
}