Skip to content

Tech debt: inconsistent dialog overflow/CSS fix approaches #283

@daveharmswebdev

Description

@daveharmswebdev

Context

PR #281 introduced CSS fixes for dialogs that get clipped, but uses three different approaches across dialogs:

  1. BatchReportDialogComponent: mat-mdc-dialog-surface { overflow: visible } + .date-field { padding-top: 8px }
  2. InlineVendorDialogComponent: mat-mdc-dialog-surface { overflow: visible }
  3. WorkOrderFormComponent: .vendor-field { padding-top: 8px } (padding-top only)

Details

  • Files:
    • frontend/src/app/features/reports/components/batch-report-dialog/batch-report-dialog.component.ts
    • frontend/src/app/features/vendors/components/inline-vendor-dialog/inline-vendor-dialog.component.ts
    • frontend/src/app/features/work-orders/components/work-order-form/work-order-form.component.ts
  • Issue: Inconsistent approaches make the codebase harder to maintain; ideally a single pattern should be used
  • Suggested fix: Standardize on one approach (e.g., a shared CSS class or a global dialog style) and apply it consistently across all affected dialogs

Acceptance Criteria

  • All dialog overflow fixes use the same pattern
  • No regression in dialog rendering (date pickers, autocompletes render without clipping)

Source

Found during PR #281 code review (Issue #7)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions