-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Context
PR #281 introduced CSS fixes for dialogs that get clipped, but uses three different approaches across dialogs:
- BatchReportDialogComponent:
mat-mdc-dialog-surface { overflow: visible }+.date-field { padding-top: 8px } - InlineVendorDialogComponent:
mat-mdc-dialog-surface { overflow: visible } - WorkOrderFormComponent:
.vendor-field { padding-top: 8px }(padding-top only)
Details
- Files:
frontend/src/app/features/reports/components/batch-report-dialog/batch-report-dialog.component.tsfrontend/src/app/features/vendors/components/inline-vendor-dialog/inline-vendor-dialog.component.tsfrontend/src/app/features/work-orders/components/work-order-form/work-order-form.component.ts
- Issue: Inconsistent approaches make the codebase harder to maintain; ideally a single pattern should be used
- Suggested fix: Standardize on one approach (e.g., a shared CSS class or a global dialog style) and apply it consistently across all affected dialogs
Acceptance Criteria
- All dialog overflow fixes use the same pattern
- No regression in dialog rendering (date pickers, autocompletes render without clipping)
Source
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels