Skip to content

Edit Vendor: Save Changes button should be disabled until form is dirty #272

@daveharmswebdev

Description

@daveharmswebdev

Bug Report — Edit Vendor: Save button active on pristine form

Found during: Manual testing of Edit Vendor form


Steps to Reproduce

  1. Navigate to any vendor's detail page
  2. Click "Edit"
  3. Observe: "Save Changes" button is immediately active/enabled without touching any field

Current Behavior

The "Save Changes" button is enabled as soon as the Edit Vendor form loads, even though no changes have been made. This allows submitting a no-op update.

Expected Behavior

The "Save Changes" button should be disabled until the form is dirty — meaning the user has actually changed at least one field value from its original state. Standard form UX:

  • Pristine form → Save button disabled
  • Dirty form (changes made) → Save button enabled
  • Dirty form reverted to original values → Save button disabled again (ideal, but at minimum dirty check is needed)

Likely Fix

The submit button needs to bind its [disabled] state to the form's pristine/dirty status, e.g.:

<button [disabled]="!form.dirty || form.invalid">Save Changes</button>

Labels: bug, frontend, vendor

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions