Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use usize for read length #21

Open
khernyo opened this issue Aug 8, 2019 · 0 comments
Open

Use usize for read length #21

khernyo opened this issue Aug 8, 2019 · 0 comments

Comments

@khernyo
Copy link
Member

khernyo commented Aug 8, 2019

Not a big deal, but RandomAccess::read() should have a length: usize param, because it's supposed to read the data into memory. The other methods should keep length: u64.

Although, it would be even better to make it more rusty: read(&mut self, offset: u64, buf: &mut [u8]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant