Skip to content

Commit 67992ca

Browse files
committed
docs: note checkClass follow-up refactor
1 parent f0cae98 commit 67992ca

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

REFACTOR_GUIDE.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,3 +369,15 @@ For each batch:
369369
3. Run `devtools::check(args = '--no-tests')` on both packages
370370
4. Run full test suite: `devtools::test(filter = "smk-|disc|arg")` to check no regressions
371371
5. Run perf tests: `PERF_DURATION_SEC=2 devtools::test(filter = "perf-")` to verify no performance regression
372+
373+
## Follow-up: refactor client-side `checkClass`
374+
375+
The client-side helper `checkClass()` currently does two jobs in one: (a) fetches the class of a server-side object and (b) checks the class is consistent across studies. After this refactor, the first job is redundant (the server returns `class` in aggregate results), but the second is still needed by composite dispatchers (`ds.summary` and similar).
376+
377+
Planned cleanup (defer to a dedicated branch):
378+
379+
- Rename `checkClass``.checkClass` to mark it internal (matches `.checkClassConsistency`, `.set_datasources`).
380+
- Split its responsibilities: one helper that fetches class for pre-call routing, one that checks cross-study consistency on a set of classes.
381+
- Update the remaining callers (`ds.summary` and any others still holding a client-side class pre-fetch).
382+
383+
Not done as part of any single batch because the rename touches callers outside that batch's function set and would break functions not yet refactored. Schedule once all batches are merged — the rename then becomes one small, isolated commit.

0 commit comments

Comments
 (0)