Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diskpart.txt created in relative path location. #168

Closed
DatKyle opened this issue Feb 6, 2022 · 2 comments
Closed

diskpart.txt created in relative path location. #168

DatKyle opened this issue Feb 6, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@DatKyle
Copy link

DatKyle commented Feb 6, 2022

Pull Request #151 Changed the diskpart logic to use a relative path(.\diskpart.txt) instead of $diskpartScriptFile ($env:APPDATA\dbaclone\diskpartcommand.txt)

This has the side effect of leaving the file in the path the command was run in.

solution

Use the $diskpartScriptFile, as previously, and add logic to create the file location on the remote instance if it doesn't exist. not sure if we want to remove the file after we have finished with it.

I'm in the process of fixing this, just raising the issue so others know of the issue.

@DatKyle DatKyle changed the title diskpart.txt persists diskpart.txt created in relative path location. Feb 6, 2022
@sanderstad sanderstad added the enhancement New feature or request label Apr 19, 2022
@lowlydba
Copy link
Contributor

Not sure if this is still needed after #205 adds functionality to cleanup the file.

@DatKyle
Copy link
Author

DatKyle commented Sep 22, 2022

No longer needed as stated above.

@DatKyle DatKyle closed this as completed Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants