Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart starts a Datahub version without matching PyPi packages #11416

Closed
edwinvehmaanpera opened this issue Sep 18, 2024 · 2 comments
Closed
Assignees
Labels
bug Bug report

Comments

@edwinvehmaanpera
Copy link

Describe the bug
When running the datahub docker quickstart it seems it now uses acryldata/datahub-frontend-react:head (which seems to be v0.14.1?) and the when trying to use ingestion it cannot create a virtual env since there is no corresponding PyPi packages. Below is how this problem presents itself when trying to ingest metadata from Postgres.

To Reproduce
Steps to reproduce the behavior:

  1. Follow Datahub Quickstart
  2. Login using demo "datahub" account
  3. Optional: to generate the below logs: Try to run metadata ingestion for Postgres
~~~~ Execution Summary - RUN_INGEST ~~~~
Execution finished with errors.
{'exec_id': '1d1c49ba-6f39-4b31-8601-56dd6ac5143a',
 'infos': ['2024-09-18 11:02:38.902353 INFO: Starting execution for task with name=RUN_INGEST',
           "2024-09-18 11:02:43.006269 INFO: Failed to execute 'datahub ingest', exit code 1",
           '2024-09-18 11:02:43.008867 INFO: Caught exception EXECUTING task_id=1d1c49ba-6f39-4b31-8601-56dd6ac5143a, name=RUN_INGEST, '
           'stacktrace=Traceback (most recent call last):\n'
           '  File "/datahub-ingestion/.venv/lib/python3.10/site-packages/acryl/executor/execution/default_executor.py", line 139, in execute_task\n'
           '    task_event_loop.run_until_complete(task_future)\n'
           '  File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete\n'
           '    return future.result()\n'
           '  File "/datahub-ingestion/.venv/lib/python3.10/site-packages/acryl/executor/execution/sub_process_ingestion_task.py", line 400, in '
           'execute\n'
           '    raise TaskError("Failed to execute \'datahub ingest\'")\n'
           "acryl.executor.execution.task.TaskError: Failed to execute 'datahub ingest'\n"],
 'errors': []}

~~~~ Ingestion Logs ~~~~
Obtaining venv creation lock...
Acquired venv creation lock
venv doesn't exist.. minting..
Using Python 3.10.12 interpreter at: /usr/bin/python3
Creating virtualenv at: /tmp/datahub/ingest/venv-postgres-3cbb1ad0ed8a0388
Resolved 3 packages in 690ms
Prepared 3 packages in 268ms
Installed 3 packages in 972ms
 + pip==24.2
 + setuptools==75.1.0
 + wheel==0.44.0
+ uv pip install 'acryl-datahub[datahub-rest,datahub-kafka,postgres]==0.14.1'
  × No solution found when resolving dependencies:
  ╰─▶ Because there is no version of acryl-datahub[postgres]==0.14.1 and
      you require acryl-datahub[postgres]==0.14.1, we can conclude that your
      requirements are unsatisfiable.

Expected behavior
Ingestion in the quickstart version works. Quickstart uses a fully supported version. Alternatively update the documentation to cover this issue.

Desktop (please complete the following information):

  • OS: Windows 11 using WSL
  • Browser Microsoft Edge Version 128.0.2739.79
@edwinvehmaanpera edwinvehmaanpera added the bug Bug report label Sep 18, 2024
@edwinvehmaanpera
Copy link
Author

edwinvehmaanpera commented Sep 19, 2024

The issue itself resolved as the PyPi packages were updated with the 0.14.1 version. However the root cause still exists and this issue is likely to happen again in future releases.

@hsheth2
Copy link
Collaborator

hsheth2 commented Sep 23, 2024

@edwinvehmaanpera you're right that we messed up the ordering of operations during the 0.14.1 release, causing it to depend on a missing CLI version.

We've fixed it by producing that release, and have also updated our internal release process to ensure this doesn't happen again.

@hsheth2 hsheth2 closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants