Creating a new release doesn't create a new release.

[bodiam]

Hi @kingthorin ,

I wanted to create a maintenance release, which I did by going to new releases -> draft new release. However, it seems our release process doesn't work like that, I have to create the release manual by triggering an action (I forgot I had to do that).

Also, I think there's a small "bug": the last version of Datafaker has been tagged 2.4.2, while all other versions are called v2.4.x, so including the v. I know it's a small issue, but consistency is nice.

Is this something you could have a look at?

[kingthorin]

Sure, will look tomorrow

[kingthorin]

I’ve re-named the 2.4.2 release on GitHub to v2.4.2. I’ll look at re-tagging it tomorrow.

It should be possible to also tag it v2.4.2 and perhaps even remove the incorrect tag.

[kingthorin]

Also for v2.4.3 it seems you made a tag not a release. Should it be an actual release and marked Latest?

[bodiam]

I made a tag as part of creating the release, but creating the release didn't create a release. I deleted the tag.

[kingthorin]

Did you create the tag via the GitHub web interface or did you push it via git?

[kingthorin]

Okay, the tags for 2.4.2 are sorted. Unfortunately the release appears to be dated today as far as GitHub is concerned, even though the tag has the proper date. 🤷‍♂️ Even the assets have the right date:

I'm not sure what to do for the future to ensure you use the workflow.

As for the v or missing-v I guess I can add something to the workflow to either make it required or add it if missing?

[bodiam]

I'm not sure what to do for the future to ensure you use the workflow.

I'm not sure what you mean. I don't want to use the workflow, I would prefer to use the releases to make a release, or is that what you mean with workflow?

As for the v or missing-v I guess I can add something to the workflow to either make it required or add it if missing?

I don't see that as required, I have never made that mistake in the past, and when you look at the existing tags, I can't imagine anyone would make that mistake either.

[kingthorin]

I'm not sure what you mean. I don't want to use the workflow, I would prefer to use the releases to make a release, or is that what you mean with workflow?

So you want to do this from the GitHub WebUI? Or you want the workflow to trigger when you push a tag to the repo?

You definitely aren't required to use the workflow, you'd just have to go through all of whatever steps you were doing before the workflow existed, I guess.

I believe we had originally put the workflow in place to allow people other than you to do releases. However, if you want to do them all we could also just remove the workflow.

I don't see that as required, I have never made that mistake in the past, and when you look at the existing tags, I can't imagine anyone would make that mistake either.

Okay I won't worry about it.

[bodiam]

I think we're miscommunicating or so, I'm not sure sure what you mean with Workflow.

I don't want to go to Actions, but instead I want to go to Releases (in the Github UI), and create a release there with a tag, the release notes, and then done.

So, I think technically, I want to trigger to github action on a new release.

But I can build this myself, we have a similar setup at work.

[kingthorin]

Okay. I sorted he v2.4.2 tag thing, you can implement the automation as you see fit 😀