Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Population_Estimates_By_ASR_Changes #1117

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Population_Estimates_By_ASR_Changes #1117

wants to merge 14 commits into from

Conversation

Bipnabraham
Copy link

No description provided.

@Bipnabraham Bipnabraham marked this pull request as ready for review November 25, 2024 07:13
krishnaswamypradeep
krishnaswamypradeep approved these changes Nov 25, 2024
View reviewed changes
Copy link

@krishnaswamypradeep krishnaswamypradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bipin. Looks good.

@Bipnabraham
Addressed comments in PR, modified future_year_url method in process.…
dba07fb 
…py, added block of code to save raw input data
@Bipnabraham
Modified state.json to remove 2023 year url and deleted national_2020…
f417c31 
…_2021.py as it is included in national_2020_2029.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaswamypradeep krishnaswamypradeep krishnaswamypradeep approved these changes

@shamimansari1988 shamimansari1988 shamimansari1988 left review comments

@ajaits ajaits ajaits left review comments

@manishvats2 manishvats2 Awaiting requested review from manishvats2

Assignees

@ajaits ajaits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bipnabraham @ajaits @shamimansari1988 @krishnaswamypradeep