[OGE-3027] Improve error messages, fix err.errors not iterable (#529)

* [OGE-3027] Improve error messages, fix err.errors not iterable

* [OGE-3027] Remove circleCI docker-version

* [OGE-3027] Merge unknown/other errors

Author: lucas-datacamp

.circleci/config.yml

@@ -23,7 +23,6 @@ workflows:
           name: docker-build
           context: org-global
           dockerfile: Dockerfile
-          docker-version: "20.10.2"
           extra-docker-args: "--build-arg VERSION=$(git describe --tags)"
           repo: rdoc-app
           executor: datacamp-artifactory/buildkit
@@ -49,7 +48,6 @@ workflows:
           artifactory-url: artifactory-proxy-public.ops.datacamp.com
           context: org-global
           dockerfile: Dockerfile
-          docker-version: "20.10.2"
           extra-docker-args: "--build-arg VERSION=$(git describe --tags)"
           repo: rdoc-app
           executor: datacamp-artifactory/buildkit

api/controllers/WorkerController.js

@@ -22,18 +22,27 @@ module.exports = {
       result.then(function(value) {
         var key = 'view_topic_' + value.id;
         RedisService.invalidateTopicById(key);
-        // console.log(value);
         res.json(value);
       })
       .catch(Sequelize.UniqueConstraintError, function (err) {
-        console.log('SequelizeError - UniqueConstraintError:', err.errors);
-        return res.send(409, err.errors);
+        console.log('SequelizeError - UniqueConstraintError:', err);
+        var errorResponse = err.errors || [{message: 'Unique constraint violation'}];
+        return res.send(409, errorResponse);
       }).catch(Sequelize.ValidationError, function (err) {
-        console.log('SequelizeError - ValidationError:', err.errors);
-        return res.send(400, err.errors);
+        console.log('SequelizeError - ValidationError:', err);
+        var errorResponse = err.errors || [{message: 'Validation error'}];
+        return res.send(400, errorResponse);
       }).catch(function(err){
-        console.log(err.errors);
-        return res.negotiate([...err.errors, "Other"]);
+        console.log('Unhandled error in Topic.createWithRdFile:', err);
+        var errorResponse = [];
+        if (err.errors && Array.isArray(err.errors)) {
+          errorResponse = [...err.errors, "Other"];
+        } else if (err.errors) {
+          errorResponse = [{message: String(err.errors)}, "Other"];
+        } else {
+          errorResponse = [{message: err.message || "Unknown error occurred"}, "Other"];
+        }
+        return res.negotiate(errorResponse);
       });
 
     } else if (type === 'version') {