fix: Use After Free in PacketReader #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
related issue: #66
Refactor
packet_reader.rs
to avoid Use After Free due to dropping Vec while still holding packets of u8 slice from it.NomBytes
type which allownom
to parsebytes::Bytes
which is smart pointer to array of u8, hence avoid uafnext()
andnext_async()
to prevent UAF or unsafe codenom
to refuse parse packets due to lack ofopt
, fixed)cargo test
is passed