fix: handle trailing zeros in Raft log WAL with EXT4 writeback mode #17042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When EXT4 is mounted with data=writeback, data and metadata (file length) can be written to disk in arbitrary order, potentially leaving trailing zeros in the WAL tail. Fix: Truncate zero bytes starting from the first un-decodable WALRecord and treat the chunk as successfully opened. This issue is fixed in the dependent crate: - drmingdrmer/raft-log@757542b
drmingdrmer
force-pushed
the
181-raft-log
branch
from
2daaf9b to
509cb46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fix: handle trailing zeros in Raft log WAL with EXT4 writeback mode
When EXT4 is mounted with data=writeback, data and metadata (file length)
can be written to disk in arbitrary order, potentially leaving trailing
zeros in the WAL tail.
Fix: Truncate zero bytes starting from the first un-decodable WALRecord
and treat the chunk as successfully opened.
This issue is fixed in the dependent crate:
chore: refine logging
Tests
Type of change
Related Issues
This change is