Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop channel if partition receiver finished #17037

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Dec 11, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix: partition receiver should implement un_reacted

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 11, 2024
@dqhl76 dqhl76 force-pushed the fix-prune-pipepine branch from 88155e1 to 78183ba Compare December 12, 2024 01:23
@dqhl76 dqhl76 changed the title fix: prune pipeline's sink should implement un_reacted fix: partition receiver should implement un_reacted Dec 12, 2024
@dqhl76 dqhl76 force-pushed the fix-prune-pipepine branch from 78183ba to 6f7ce75 Compare December 12, 2024 02:24
@dqhl76 dqhl76 marked this pull request as ready for review December 12, 2024 03:51
@zhang2014 zhang2014 changed the title fix: partition receiver should implement un_reacted fix: drop channel if partition receiver finished Dec 12, 2024
@zhang2014 zhang2014 enabled auto-merge December 12, 2024 05:28
@zhang2014 zhang2014 added this pull request to the merge queue Dec 12, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 12, 2024
@BohuTANG BohuTANG merged commit d46605e into databendlabs:main Dec 12, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants