Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: improve OrNull aggregate function adaptor #16984

Open
sundy-li opened this issue Dec 2, 2024 · 0 comments
Open

Feature: improve OrNull aggregate function adaptor #16984

sundy-li opened this issue Dec 2, 2024 · 0 comments
Assignees
@forsaken628
Labels
C-feature Category: feature

Comments

@sundy-li
Copy link
Member

sundy-li commented Dec 2, 2024

Summary

Description for this feature.

Currently, we have OrNull aggregate function adaptor as follows:

An SQL with three aggregate functions.

[InnerState1  FLAG1]  ---  [InnerState2  FLAG2] ---  [InnerState2  FLAG3]

we can optimize the FLAG state into one sate, like:

[InnerState1 ---- InnerState2 ---- InnerState2  FLAG]

It could save lots of allocations for high cardinality queries
@sundy-li sundy-li added the C-feature Category: feature label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@forsaken628 forsaken628

Labels
C-feature Category: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sundy-li @forsaken628