BUG: avoid generating numpy scalars in test_asarray_arrays

ev-br · ev-br · commit 0f59c216262f · 2024-11-20T15:07:39.000+02:00
Otherwise, on numpy we can generate a numpy scalar and copy=False,
which fails with

(Pdb) p np.asarray(np.False_, copy=False)
*** ValueError: Unable to avoid copy while creating an array as requested.
diff --git a/array_api_tests/test_creation_functions.py b/array_api_tests/test_creation_functions.py
@@ -263,7 +263,7 @@ def scalar_eq(s1: Scalar, s2: Scalar) -> bool:
     data=st.data(),
 )
 def test_asarray_arrays(shape, dtypes, data):
-    x = data.draw(hh.arrays(dtype=dtypes.input_dtype, shape=shape), label="x")
+    x = data.draw(hh.arrays_no_scalars(dtype=dtypes.input_dtype, shape=shape), label="x")
     dtypes_strat = st.just(dtypes.input_dtype)
     if dtypes.input_dtype == dtypes.result_dtype:
         dtypes_strat |= st.none()

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ def scalar_eq(s1: Scalar, s2: Scalar) -> bool:`
`263`	`263`	`data=st.data(),`
`264`	`264`	`)`
`265`	`265`	`def test_asarray_arrays(shape, dtypes, data):`
`266`		`- x = data.draw(hh.arrays(dtype=dtypes.input_dtype, shape=shape), label="x")`
	`266`	`+ x = data.draw(hh.arrays_no_scalars(dtype=dtypes.input_dtype, shape=shape), label="x")`
`267`	`267`	`dtypes_strat = st.just(dtypes.input_dtype)`
`268`	`268`	`if dtypes.input_dtype == dtypes.result_dtype:`
`269`	`269`	`dtypes_strat \|= st.none()`