Allow any combination of real dtypes in comparisons #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not change == or != because the standard is currently unclear about that so I'd like to see what happens there first.
Also update elementwise function tests to check for disallowed type promotions, not just disallowed mixed kind types.
|
Actually I went ahead and updated equal/not_equal/==/!= because it was easier. |
|
The test suite needs to be updated to test for this (and that will need to wait for update to the spec). I need this to unblock the CI here for #49 which is also blocking the test suite CI. |
|
It's looking like the standard is going to be updated to match the existing behavior, so this should be reverted data-apis/array-api#822. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change == or != because the standard is currently unclear about that so I'd like to see what happens there first.