chore: update GitHub Actions to use ubuntu-22.04-arm for all jobs (#169)

* chore: update GitHub Actions to use ubuntu-22.04-arm for all jobs

* fix(ffi): use c_char instead of i8 for platform-agnostic FFI types

Replace hardcoded i8 casts with c_char to fix ARM compilation errors.
On ARM architectures, c_char is u8 (not i8 as on x86/x86_64), causing
type mismatches in FFI test code.

- Replace all *mut i8 and *const i8 casts with c_char equivalents
- Update array declarations from [0i8; N] to [0u8; N] with proper casting
- Add c_char import to all affected test files

* fix(ffi): use .cast() instead of as cast for raw pointer conversion

Replace 'as *mut u8' casts with .cast::<u8>() method to fix clippy
warnings about unnecessary casts on ARM architectures.

On ARM, c_char is u8, making the explicit cast unnecessary. Using
.cast::<u8>() is the modern Rust approach and avoids clippy warnings
while maintaining platform compatibility.

Author: PastaPastaPasta

.github/workflows/fuzz.yml

@@ -18,7 +18,7 @@ concurrency:
 jobs:
   fuzz:
     if: ${{ !github.event.act }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     strategy:
       fail-fast: false
       matrix:
@@ -66,7 +66,7 @@ jobs:
   verify-execution:
     if: ${{ !github.event.act }}
     needs: fuzz
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - uses: actions/checkout@v4
       - uses: actions/download-artifact@v4

.github/workflows/rust.yml

@@ -20,7 +20,7 @@ jobs:
     permissions:
       contents: read
       pull-requests: write
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v4
@@ -140,7 +140,7 @@ jobs:
 
   key_wallet_tests:
     name: Key Wallet Components Tests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v4
@@ -157,7 +157,7 @@ jobs:
 
   core_components_tests:
     name: Core Components Tests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v4
@@ -178,7 +178,7 @@ jobs:
 
   clippy:
     name: Clippy (Non-strict)
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v4
@@ -201,7 +201,7 @@ jobs:
 
   strict-checks:
     name: Strict Warnings and Clippy Checks
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v4
@@ -298,7 +298,7 @@ jobs:
 
   fmt:
     name: Format
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - name: Checkout Crate
         uses: actions/checkout@v4
@@ -311,7 +311,7 @@ jobs:
 
   rpc_tests:
     name: RPC Tests
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     strategy:
       matrix:
         include:
@@ -330,7 +330,7 @@ jobs:
   integrations_tests:
     name: Integration Tests
     if: ${{ false }} # Temporarily disabled
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     strategy:
       matrix:
         rust: [stable]
@@ -347,7 +347,7 @@ jobs:
 
   actionlint:
     name: Lint GitHub Actions
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     permissions:
       contents: read
     steps:

.github/workflows/verify-ffi-docs.yml

@@ -22,7 +22,7 @@ on:
 
 jobs:
   verify-key-wallet-docs:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -53,7 +53,7 @@ jobs:
           fi
 
   verify-dash-spv-docs:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -84,7 +84,7 @@ jobs:
           fi
 
   update-docs-comment:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04-arm
     if: failure() && github.event_name == 'pull_request'
     needs:
       - verify-key-wallet-docs

key-wallet-ffi/src/account_derivation_tests.rs

@@ -9,6 +9,8 @@ mod tests {
     use crate::keys::{extended_private_key_free, private_key_free};
     use crate::types::{FFIAccountType, FFINetworks};
     use crate::wallet;
+    use std::ffi::CString;
+    use std::os::raw::c_char;
 
     const MNEMONIC: &str =
         "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about";
@@ -215,7 +217,7 @@ mod tests {
     }
 
     // Helper to make C string pointers
-    fn c_str(s: &str) -> *const i8 {
+    fn c_str(s: &str) -> *const c_char {
         std::ffi::CString::new(s).unwrap().as_ptr()
     }
 }

key-wallet-ffi/src/derivation.rs

@@ -131,7 +131,7 @@ pub extern "C" fn derivation_bip44_account_path(
     }
 
     unsafe {
-        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
+        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
     }
 
     FFIError::set_success(error);
@@ -189,7 +189,7 @@ pub extern "C" fn derivation_bip44_payment_path(
     }
 
     unsafe {
-        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
+        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
     }
 
     FFIError::set_success(error);
@@ -244,7 +244,7 @@ pub extern "C" fn derivation_coinjoin_path(
     }
 
     unsafe {
-        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
+        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
     }
 
     FFIError::set_success(error);
@@ -299,7 +299,7 @@ pub extern "C" fn derivation_identity_registration_path(
     }
 
     unsafe {
-        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
+        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
     }
 
     FFIError::set_success(error);
@@ -356,7 +356,7 @@ pub extern "C" fn derivation_identity_topup_path(
     }
 
     unsafe {
-        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
+        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
     }
 
     FFIError::set_success(error);
@@ -417,7 +417,7 @@ pub extern "C" fn derivation_identity_authentication_path(
     }
 
     unsafe {
-        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out as *mut u8, bytes.len());
+        ptr::copy_nonoverlapping(bytes.as_ptr(), path_out.cast::<u8>(), bytes.len());
     }
 
     FFIError::set_success(error);