perf: std::move a shared_ptr with islock in ProcessMessage

Author: knst

src/instantsend/instantsend.cpp

@@ -66,7 +66,7 @@ CInstantSendManager::~CInstantSendManager() = default;
 bool ShouldReportISLockTiming() { return g_stats_client->active() || LogAcceptDebug(BCLog::INSTANTSEND); }
 
 void CInstantSendManager::EnqueueInstantSendLock(NodeId from, const uint256& hash,
-                                                 const std::shared_ptr<instantsend::InstantSendLock>& islock)
+                                                 std::shared_ptr<instantsend::InstantSendLock> islock)
 {
     if (ShouldReportISLockTiming()) {
         auto time_diff = [&]() -> int64_t {
@@ -86,7 +86,7 @@ void CInstantSendManager::EnqueueInstantSendLock(NodeId from, const uint256& has
     }
 
     LOCK(cs_pendingLocks);
-    pendingInstantSendLocks.emplace(hash, instantsend::PendingISLockFromPeer{from, islock});
+    pendingInstantSendLocks.emplace(hash, instantsend::PendingISLockFromPeer{from, std::move(islock)});
 }
 
 instantsend::PendingState CInstantSendManager::FetchPendingLocks()

src/instantsend/instantsend.h

@@ -135,7 +135,7 @@ class CInstantSendManager final : public instantsend::InstantSendSignerParent
     /* Helpers for communications between CInstantSendManager & NetInstantSend */
     // This helper returns up to 32 pending locks and remove them from queue of pending
     [[nodiscard]] instantsend::PendingState FetchPendingLocks() EXCLUSIVE_LOCKS_REQUIRED(!cs_pendingLocks);
-    void EnqueueInstantSendLock(NodeId from, const uint256& hash, const std::shared_ptr<instantsend::InstantSendLock>& islock)
+    void EnqueueInstantSendLock(NodeId from, const uint256& hash, std::shared_ptr<instantsend::InstantSendLock> islock)
         EXCLUSIVE_LOCKS_REQUIRED(!cs_pendingLocks);
     [[nodiscard]] std::vector<CTransactionRef> PrepareTxToRetry()
         EXCLUSIVE_LOCKS_REQUIRED(!cs_nonLocked, !cs_pendingRetry);

src/instantsend/net_instantsend.cpp

@@ -22,7 +22,7 @@ void NetInstantSend::ProcessMessage(CNode& pfrom, const std::string& msg_type, C
 
     if (!m_is_manager.IsInstantSendEnabled()) return;
 
-    const auto islock = std::make_shared<instantsend::InstantSendLock>();
+    auto islock = std::make_shared<instantsend::InstantSendLock>();
     vRecv >> *islock;
 
     uint256 hash = ::SerializeHash(*islock);
@@ -60,7 +60,7 @@ void NetInstantSend::ProcessMessage(CNode& pfrom, const std::string& msg_type, C
         LogPrint(BCLog::INSTANTSEND, "NetInstantSend -- ISDLOCK txid=%s, islock=%s: received islock, peer=%d\n",
                  islock->txid.ToString(), hash.ToString(), pfrom.GetId());
 
-        m_is_manager.EnqueueInstantSendLock(pfrom.GetId(), hash, islock);
+        m_is_manager.EnqueueInstantSendLock(pfrom.GetId(), hash, std::move(islock));
     }
 }