Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wildcard handling in tests for proper debugging behavior #2570

Open
jyameo opened this issue Jan 16, 2025 · 1 comment
Open

Update wildcard handling in tests for proper debugging behavior #2570

jyameo opened this issue Jan 16, 2025 · 1 comment

Comments

@jyameo
Copy link
Contributor

jyameo commented Jan 16, 2025

Description:
Currently, the wildcard variable in the test is handled inconsistently between the library bundle format and the AMD module format. The CFE now renames wildcards to temporary variables as multiple wildcards can exist.

Library bundle format: Correctly excludes the wildcard variable from debugging.
AMD module format: Emits _ instead of a temporary name.

Per the discussion with DDC folks, it was agreed that wildcard variables are not expected to be available via debugging. Therefore, the library bundle format's behavior is correct, while the AMD format's behavior might not be.

@srujzs
Copy link
Contributor

srujzs commented Jan 16, 2025

Thanks for filing!

while the AMD format's behavior might not be

might is a good qualifier. It's undefined behavior on what a wildcard's JS name should be. Because of that, _ is a totally valid JS name as long as it doesn't conflict, but it'll require a bit more testing to determine if it's doing something erroneous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants