Skip to content

Commit fcd906f

Browse files
srujzssrujzs
authored
Add ignores for deprecated web libraries with a TODO and move dwds to 24.4.0-wip (#2559)
Dart web libraries are now deprecated. This triggers a lint which we fail on. We should migrate these to dart:js_interop and package:web, but for now, ignore to make CI happy. This also moves the CHANGELOG, pubspec, and version.dart files to 24.4.0-wip, which is needed for proper_release_test to pass.
1 parent e72f365 commit fcd906f

File tree

23 files changed

+53
-2
lines changed

23 files changed

+53
-2
lines changed

‎dwds/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
## 24.4.0-wip
2+
13
## 24.3.0
24

35
- Update to be forward compatible with changes to `package:shelf_web_socket`.

‎dwds/debug_extension/web/chrome_api.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// TODO: https://github.com/dart-lang/webdev/issues/2508
6+
// ignore: deprecated_member_use
57
import 'dart:html';
68

79
import 'package:js/js.dart';

‎dwds/debug_extension/web/cider_connection.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
library;
77

88
import 'dart:convert';
9+
// TODO: https://github.com/dart-lang/webdev/issues/2508
10+
// ignore: deprecated_member_use
911
import 'dart:js_util';
1012

1113
import 'package:js/js.dart';

‎dwds/debug_extension/web/copier.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
@JS()
66
library;
77

8+
// TODO: https://github.com/dart-lang/webdev/issues/2508
9+
// ignore: deprecated_member_use
810
import 'dart:html';
911

1012
import 'package:js/js.dart';

‎dwds/debug_extension/web/debug_info.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
library;
77

88
import 'dart:convert';
9+
// TODO: https://github.com/dart-lang/webdev/issues/2508
10+
// ignore: deprecated_member_use
911
import 'dart:html';
12+
// TODO: https://github.com/dart-lang/webdev/issues/2508
13+
// ignore: deprecated_member_use
1014
import 'dart:js';
1115

1216
import 'package:dwds/data/debug_info.dart';

‎dwds/debug_extension/web/detector.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
library;
77

88
import 'dart:convert';
9+
// TODO: https://github.com/dart-lang/webdev/issues/2508
10+
// ignore: deprecated_member_use
911
import 'dart:html';
12+
// TODO: https://github.com/dart-lang/webdev/issues/2508
13+
// ignore: deprecated_member_use
1014
import 'dart:js_util';
1115

1216
import 'package:dwds/data/debug_info.dart';

‎dwds/debug_extension/web/devtools.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
@JS()
66
library;
77

8+
// TODO: https://github.com/dart-lang/webdev/issues/2508
9+
// ignore: deprecated_member_use
810
import 'dart:html';
911

1012
import 'package:dwds/data/debug_info.dart';

‎dwds/debug_extension/web/messaging.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ library;
77

88
import 'dart:async';
99
import 'dart:convert';
10+
// TODO: https://github.com/dart-lang/webdev/issues/2508
11+
// ignore: deprecated_member_use
1012
import 'dart:js_util';
1113

1214
import 'package:js/js.dart';

‎dwds/debug_extension/web/panel.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ library;
77

88
import 'dart:async';
99
import 'dart:convert';
10+
// TODO: https://github.com/dart-lang/webdev/issues/2508
11+
// ignore: deprecated_member_use
1012
import 'dart:html';
1113

1214
import 'package:dwds/data/debug_info.dart';

‎dwds/debug_extension/web/popup.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ library;
77

88
import 'dart:async';
99
import 'dart:convert';
10+
// TODO: https://github.com/dart-lang/webdev/issues/2508
11+
// ignore: deprecated_member_use
1012
import 'dart:html';
1113

1214
import 'package:dwds/data/debug_info.dart';

‎dwds/debug_extension/web/storage.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ library;
77

88
import 'dart:async';
99
import 'dart:convert';
10+
// TODO: https://github.com/dart-lang/webdev/issues/2508
11+
// ignore: deprecated_member_use
1012
import 'dart:js_util';
1113

1214
import 'package:js/js.dart';

‎dwds/debug_extension/web/utils.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
library;
77

88
import 'dart:async';
9+
// TODO: https://github.com/dart-lang/webdev/issues/2508
10+
// ignore: deprecated_member_use
911
import 'dart:js_util';
1012

1113
import 'package:js/js.dart';

‎dwds/debug_extension/web/web_api.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
4+
5+
// TODO: https://github.com/dart-lang/webdev/issues/2508
6+
// ignore: deprecated_member_use
47
import 'dart:html';
8+
// TODO: https://github.com/dart-lang/webdev/issues/2508
9+
// ignore: deprecated_member_use
510
import 'dart:js_util' as js_util;
611

712
import 'package:js/js.dart';

‎dwds/lib/src/version.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dwds/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dwds
22
# Every time this changes you need to run `dart run build_runner build`.
3-
version: 24.3.0
3+
version: 24.4.0-wip
44
description: >-
55
A service that proxies between the Chrome debug protocol and the Dart VM
66
service protocol.

‎example/web/main.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
import 'dart:async';
66
import 'dart:convert';
77
import 'dart:developer';
8+
// TODO: https://github.com/dart-lang/webdev/issues/2508
9+
// ignore: deprecated_member_use
810
import 'dart:html';
911

1012
void main() {

‎fixtures/_experimentSound/web/main.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
import 'dart:async';
66
import 'dart:core';
7+
// TODO: https://github.com/dart-lang/webdev/issues/2508
8+
// ignore: deprecated_member_use
79
import 'dart:html';
810

911
void main() {

‎fixtures/_testCircular2Sound/web/main.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
import 'dart:async';
66
import 'dart:core';
7+
// TODO: https://github.com/dart-lang/webdev/issues/2508
8+
// ignore: deprecated_member_use
79
import 'dart:html';
810

911
import 'package:_test_circular1_sound/library1.dart';

‎fixtures/_testHotRestart2Sound/web/main.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'dart:core';
6+
// TODO: https://github.com/dart-lang/webdev/issues/2508
7+
// ignore: deprecated_member_use
68
import 'dart:html';
79

810
import 'package:_test_hot_restart1/library1.dart';

‎fixtures/_testPackageSound/web/main.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ import 'dart:async';
66
import 'dart:convert';
77
import 'dart:core';
88
import 'dart:developer';
9+
// TODO: https://github.com/dart-lang/webdev/issues/2508
10+
// ignore: deprecated_member_use
911
import 'dart:html';
1012

1113
import 'package:_test_package_sound/test_library.dart';

‎fixtures/_testSound/example/append_body/main.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
import 'dart:async';
66
import 'dart:developer';
7+
// TODO: https://github.com/dart-lang/webdev/issues/2508
8+
// ignore: deprecated_member_use
79
import 'dart:html';
810

911
void main() {

‎fixtures/_testSound/example/hello_world/main.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@ import 'dart:async';
66
import 'dart:collection';
77
import 'dart:convert';
88
import 'dart:developer';
9+
// TODO: https://github.com/dart-lang/webdev/issues/2508
10+
// ignore: deprecated_member_use
911
import 'dart:html';
12+
// TODO: https://github.com/dart-lang/webdev/issues/2508
13+
// ignore: deprecated_member_use
1014
import 'dart:js';
1115

1216
import 'package:intl/intl.dart';

‎fixtures/_webdevSoundSmoke/web/main.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
import 'dart:async';
66
import 'dart:convert';
77
import 'dart:developer';
8+
// TODO: https://github.com/dart-lang/webdev/issues/2508
9+
// ignore: deprecated_member_use
810
import 'dart:html';
911

1012
void main() {

0 commit comments

Comments
 (0)