Skip to content

Commit 8b7cb48

Browse files
author
Anna Gringauze
authored
Prep to publish dwds (#1388)
* Update versions and build * Addressed CR comments - Changed min sdk constraint to 2.13.0, updated changelog. * Update dds and vm_service, prep to publish dwds * Fixed analyzer warnings
1 parent 832b096 commit 8b7cb48

File tree

5 files changed

+17
-6
lines changed

5 files changed

+17
-6
lines changed

dwds/CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 11.2.2
2+
3+
- Depend on `dds` version `2.1.1`.
4+
- Depend on `vm_service` vesrion `7.2.0`.
5+
16
## 11.2.1
27

38
- Recover from used port errors when starting debug service.

dwds/lib/src/debugging/classes.dart

+4-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,10 @@ class ClassHelper extends Domain {
160160
name: name,
161161
owner: classRef,
162162
isConst: descriptor['isConst'] as bool,
163-
isStatic: descriptor['isStatic'] as bool));
163+
isStatic: descriptor['isStatic'] as bool,
164+
// TODO(annagrin): get information about getters and setters from symbols.
165+
// https://github.com/dart-lang/sdk/issues/46723
166+
implicit: false));
164167
});
165168
var fieldRefs = <FieldRef>[];
166169
var fieldDescriptors = classDescriptor['fields'] as Map<String, dynamic>;

dwds/lib/src/debugging/instance.dart

+4-1
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,10 @@ class InstanceHelper extends Domain {
414414
// TODO(alanknight): The right ClassRef
415415
owner: classRefForUnknown,
416416
isConst: false,
417-
isStatic: false)
417+
isStatic: false,
418+
// TODO(annagrin): get information about getters and setters from symbols.
419+
// https://github.com/dart-lang/sdk/issues/46723
420+
implicit: false)
418421
..closureContext = (ContextRef(length: 0, id: createId()));
419422
default:
420423
// Return null for an unsupported type. This is likely a JS construct.

dwds/lib/src/version.dart

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dwds/pubspec.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dwds
22
# Every time this changes you need to run `pub run build_runner build`.
3-
version: 11.2.1
3+
version: 11.2.2
44
homepage: https://github.com/dart-lang/webdev/tree/master/dwds
55
description: >-
66
A service that proxies between the Chrome debug protocol and the Dart VM
@@ -14,7 +14,7 @@ dependencies:
1414
built_collection: ^5.0.0
1515
built_value: '>=6.7.0 <9.0.0'
1616
crypto: '>=2.0.6 <4.0.0'
17-
dds: ^2.0.0
17+
dds: ^2.1.1
1818
http: '>=0.12.0 <0.14.0'
1919
http_multi_server: ^3.0.0
2020
logging: '>=0.11.3 <2.0.0'
@@ -32,7 +32,7 @@ dependencies:
3232
source_maps: ^0.10.0
3333
sse: ^4.1.0
3434
# We pin the version because we implement the interface.
35-
vm_service: 7.1.1
35+
vm_service: 7.2.0
3636
web_socket_channel: ^2.0.0
3737
webkit_inspection_protocol: ^1.0.0
3838

0 commit comments

Comments
 (0)