Cleanup unused null-safety options

Author: nshahan

dwds/lib/src/services/expression_compiler_service.dart

@@ -78,7 +78,6 @@ class _Compiler {
       '--module-format',
       compilerOptions.moduleFormat.name,
       if (verbose) '--verbose',
-      '--sound-null-safety',
       for (final experiment in compilerOptions.experiments)
         '--enable-experiment=$experiment',
       if (compilerOptions.canaryFeatures) '--canary',

frontend_server_client/example/web_client.dart

@@ -27,7 +27,6 @@ void main(List<String> args) async {
       '--multi-root-scheme=org-dartlang-sdk',
       '--modules=amd',
       '--module-name=dart_sdk',
-      '--sound-null-safety',
       '-o',
       dartSdkJs,
       p.url.join(sdkDir, sdkKernelPath),

frontend_server_common/lib/src/frontend_server_client.dart

@@ -394,7 +394,6 @@ class ResidentCompiler {
       ],
       if (useDebuggerModuleNames) '--debugger-module-names',
       '--experimental-emit-debug-metadata',
-      '--sound-null-safety',
       for (final experiment in compilerOptions.experiments)
         '--enable-experiment=$experiment',
       if (compilerOptions.canaryFeatures) '--dartdevc-canary',

webdev/CHANGELOG.md

@@ -1,4 +1,6 @@
 ## 3.8.0-wip
+ - Remove deprecated `--null-safety` flag. All Dart 3 compiles use sound null
+   safety.
 
 ## 3.7.2
 

webdev/lib/src/command/configuration.dart

@@ -30,10 +30,6 @@ const releaseFlag = 'release';
 const requireBuildWebCompilersFlag = 'build-web-compilers';
 const enableExpressionEvaluationFlag = 'enable-expression-evaluation';
 const verboseFlag = 'verbose';
-const nullSafetyFlag = 'null-safety';
-const nullSafetySound = 'sound';
-const nullSafetyUnsound = 'unsound';
-const nullSafetyAuto = 'auto';
 const disableDdsFlag = 'disable-dds';
 const enableExperimentOption = 'enable-experiment';
 const canaryFeaturesFlag = 'canary';
@@ -105,7 +101,6 @@ class Configuration {
   final bool? _enableExpressionEvaluation;
   final bool? _verbose;
   final bool? _disableDds;
-  final String? _nullSafety;
   final List<String>? _experiments;
   final bool? _canaryFeatures;
   final bool? _offline;
@@ -132,7 +127,6 @@ class Configuration {
     bool? enableExpressionEvaluation,
     bool? verbose,
     bool? disableDds,
-    String? nullSafety,
     List<String>? experiments,
     bool? canaryFeatures,
     bool? offline,
@@ -155,7 +149,6 @@ class Configuration {
         _disableDds = disableDds,
         _enableExpressionEvaluation = enableExpressionEvaluation,
         _verbose = verbose,
-        _nullSafety = nullSafety,
         _experiments = experiments,
         _canaryFeatures = canaryFeatures,
         _offline = offline {
@@ -231,7 +224,6 @@ class Configuration {
       enableExpressionEvaluation:
           other._enableExpressionEvaluation ?? _enableExpressionEvaluation,
       verbose: other._verbose ?? _verbose,
-      nullSafety: other._nullSafety ?? _nullSafety,
       experiments: other._experiments ?? _experiments,
       canaryFeatures: other._canaryFeatures ?? _canaryFeatures,
       offline: other._offline ?? _offline);
@@ -278,13 +270,6 @@ class Configuration {
 
   bool get verbose => _verbose ?? false;
 
-  /// Null safety mode:
-  ///
-  /// 'sound', 'unsound', or 'auto'.
-  /// 'auto' indicates that the default `package:build_web_compilers`
-  /// behavior should be used.
-  String get nullSafety => _nullSafety ?? 'auto';
-
   List<String> get experiments => _experiments ?? [];
 
   bool get canaryFeatures => _canaryFeatures ?? false;
@@ -398,10 +383,6 @@ class Configuration {
         ? argResults[verboseFlag] as bool?
         : defaultConfiguration.verbose;
 
-    final nullSafety = argResults.options.contains(nullSafetyFlag)
-        ? argResults[nullSafetyFlag] as String?
-        : defaultConfiguration.nullSafety;
-
     final disableDds = argResults.options.contains(disableDdsFlag)
         ? argResults[disableDdsFlag] as bool?
         : defaultConfiguration.disableDds;
@@ -441,7 +422,6 @@ class Configuration {
       disableDds: disableDds,
       enableExpressionEvaluation: enableExpressionEvaluation,
       verbose: verbose,
-      nullSafety: nullSafety,
       experiments: experiments,
       canaryFeatures: canaryFeatures,
       offline: offline,

webdev/lib/src/command/shared.dart

@@ -30,15 +30,8 @@ void addSharedArgs(ArgParser argParser,
     )
     ..addOption(nullSafetyFlag,
         abbr: 'n',
-        defaultsTo: nullSafetyAuto,
-        allowed: [nullSafetySound, nullSafetyUnsound, nullSafetyAuto],
-        help:
-            'DEPRECATED: If "sound", `package:build_web_compilers` will be run '
-            'with sound null safety support. '
-            'If "unsound", `package:build_web_compilers` will be run without '
-            'sound null safety support. '
-            'If "auto", the default `package:build_web_compilers` '
-            'behavior is used.',
+        help: 'DEPRECATED: This flag is ignored and will be removed in an'
+            'upcoming release.',
         hide: true)
     ..addFlag(releaseFlag,
         abbr: 'r',

webdev/test/configuration_test.dart

@@ -12,7 +12,6 @@ void main() {
     argParser = ArgParser()
       ..addFlag('release')
       ..addFlag(launchInChromeFlag, defaultsTo: false)
-      ..addOption(nullSafetyFlag, defaultsTo: nullSafetyAuto)
       ..addOption(userDataDirFlag, defaultsTo: null);
   });
 
@@ -71,12 +70,6 @@ void main() {
         throwsA(isA<InvalidConfiguration>()));
   });
 
-  test('nullSafety defaults to auto', () {
-    final argResults = argParser.parse(['']);
-    final defaultConfiguration = Configuration.fromArgs(argResults);
-    expect(defaultConfiguration.nullSafety, equals(nullSafetyAuto));
-  });
-
   test(
       'must not provide debug related configuration when enableInjectedClient '
       'is false', () {