Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More info about pub publish validations #6246

Open
MaryaBelanger opened this issue Dec 2, 2024 · 2 comments
Open

More info about pub publish validations #6246

MaryaBelanger opened this issue Dec 2, 2024 · 2 comments
Assignees
Labels
a.reference Relates to reference material section of dart.dev e1-hours Can complete in < 8 hours of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.

Comments

@MaryaBelanger
Copy link
Contributor

MaryaBelanger commented Dec 2, 2024

https://dart.dev/tools/pub/cmd/pub-lish

pub publish completes several layers of validation that would be worth describing on it's page (not much other info there currently)

Ideally will redo / undo this change because it doesn't really make sense to only mention that one kind of validation in the publishing step, because:

  1. many different kinds of validations happen, not just the clean git state, and
  2. validations happen for both test publishing and real publishing, but that PR only adds the validation to the "real" publishing section.

It'd be better to have either a short section about validations before both the test publish and real publish sections, or a section about validation on the command page that those sections can link to, or both.

@MaryaBelanger MaryaBelanger added p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. e1-hours Can complete in < 8 hours of normal, not dedicated, work a.reference Relates to reference material section of dart.dev labels Dec 2, 2024
@MaryaBelanger MaryaBelanger self-assigned this Dec 6, 2024
@MaryaBelanger
Copy link
Contributor Author

@sigurdm are all the validators here run for pub publish or are some of them related to different pub commands?

@sigurdm
Copy link
Contributor

sigurdm commented Dec 9, 2024

@sigurdm are all the validators here run for pub publish or are some of them related to different pub commands?

Yes they are, but the source of truth would be this list:
https://github.com/dart-lang/pub/blob/master/lib/src/validator.dart#L143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.reference Relates to reference material section of dart.dev e1-hours Can complete in < 8 hours of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.
Projects
None yet
Development

No branches or pull requests

2 participants