-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document pub workspaces #6117
Document pub workspaces #6117
Conversation
Visit the preview URL for this PR (updated for commit fc13a5f): https://dart-dev--pr6117-document-workspaces-r9fkahhq.web.app |
…-www into document_workspaces
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
I'm not sure what the issue with the tests is, but I get the same thing locally. Maybe @parlough can help? Edit: Yeah, I see he made a possibly similar fix earlier in this pr. I'm not sure what he did there and I don't want to mess anything up, so we'll wait for that and then merge this! |
Thanks so much @parlough! I just noticed it says "should only be merged with 3.6", so I won't merge it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos
Edit: I actually ended up undoing all of this and removing the mention of analysis context based on Brian's comment here, I think that makes much more sense. |
This reverts commit 32c2ffc.
I made an extension to this PR in sigurdm#1. That should probably only land if we get dart-lang/sdk#59650 cherry picked. |
@parlough Since you've been working on moving things out from under /guides, where do you suggest we place this new page? |
Fixes #5891
Should probably only land with 3.6