Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pub workspaces #6117

Merged
merged 47 commits into from
Dec 10, 2024
Merged

Document pub workspaces #6117

merged 47 commits into from
Dec 10, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Sep 30, 2024

Fixes #5891

Should probably only land with 3.6

@sigurdm sigurdm requested a review from jonasfj September 30, 2024 12:29
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Sep 30, 2024

Visit the preview URL for this PR (updated for commit fc13a5f):

https://dart-dev--pr6117-document-workspaces-r9fkahhq.web.app

@parlough parlough self-requested a review September 30, 2024 19:54
@sigurdm sigurdm requested a review from szakarias October 1, 2024 12:42
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
src/content/guides/packages.md Outdated Show resolved Hide resolved
@MaryaBelanger
Copy link
Contributor

MaryaBelanger commented Nov 14, 2024

I'm not sure what the issue with the tests is, but I get the same thing locally. Maybe @parlough can help?

Edit: Yeah, I see he made a possibly similar fix earlier in this pr. I'm not sure what he did there and I don't want to mess anything up, so we'll wait for that and then merge this!

@MaryaBelanger
Copy link
Contributor

Thanks so much @parlough!

I just noticed it says "should only be merged with 3.6", so I won't merge it now.

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

@MaryaBelanger
Copy link
Contributor

MaryaBelanger commented Nov 26, 2024

@sigurdm I added d017546 to "close the loop" about analysis contexts, since you mentioned that without workspaces, analysis contexts cause performance issues. So I added a quick line to to confirm that with workspaces, analysis performance will improve.

The link on analysis context will land with #6239

Edit: I actually ended up undoing all of this and removing the mention of analysis context based on Brian's comment here, I think that makes much more sense.

@sigurdm
Copy link
Contributor Author

sigurdm commented Dec 3, 2024

I made an extension to this PR in sigurdm#1. That should probably only land if we get dart-lang/sdk#59650 cherry picked.

@MaryaBelanger
Copy link
Contributor

@parlough Since you've been working on moving things out from under /guides, where do you suggest we place this new page?

@parlough parlough merged commit d17d198 into dart-lang:main Dec 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document new workspaces feature
7 participants