refactor(Null safety): fix typo about number of core design principles #5154
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
atsansone
added
cla: no
There was a problem hiding this comment.
Thanks for the PR!
Before we can review and incorporate the change, you'll have to sign the Google CLA as outlined in the earlier PR comment with the same email as you committed with: #5154 (comment)
Once that is complete, we'd be happy to take another look. Thank you!
|
/rerun |
Hi @parlough
|
google-cla
bot
added
cla: yes
|
Thanks for the response and I'm really sorry about the back and forth... I appreciate the PR and your patience. I re-ran the CLA check and it seems it's still failing. Check the workflow for more information (https://github.com/dart-lang/site-www/pull/5154/checks?check_run_id=16833416591), but it seems the commit was made with your hidden GitHub email. The workflow failure explains more, but you may need to add that to your CLA or recommit with the email you signed the CLA with. |
#5154) * Fix a typo about number of core design principles mentioned afterwards --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. - [x] This PR doesn’t contain automatically generated corrections or text (Grammarly, LLMs, and similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/site-www/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Code changes should generally follow the [Dart style guide](https://dart.dev/effective-dart) and use `dart format`. - Updates to [code excerpts](https://github.com/dart-lang/site-shared/blob/main/doc/code-excerpts.md) indicated by `<?code-excerpt` need to be updated in their source `.dart` file as well. </details> Co-authored-by: Anthony Sansone <[email protected]>
dart-lang#5154) * Fix a typo about number of core design principles mentioned afterwards --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. - [x] This PR doesn’t contain automatically generated corrections or text (Grammarly, LLMs, and similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/site-www/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Code changes should generally follow the [Dart style guide](https://dart.dev/effective-dart) and use `dart format`. - Updates to [code excerpts](https://github.com/dart-lang/site-shared/blob/main/doc/code-excerpts.md) indicated by `<?code-excerpt` need to be updated in their source `.dart` file as well. </details> Co-authored-by: Anthony Sansone <[email protected]>
Contribution guidelines:
dart format.<?code-excerptneed to be updated in their source.dartfile as well.