Skip to content

core library updates for enhanced enums #47864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #47849
devoncarew opened this issue Dec 6, 2021 · 3 comments
Closed
Tracked by #47849

core library updates for enhanced enums #47864

devoncarew opened this issue Dec 6, 2021 · 3 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-task A well-defined stand-alone task

Comments

@devoncarew
Copy link
Member

See #47849 for the main tracking issue.

@devoncarew devoncarew added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Dec 6, 2021
@lrhn
Copy link
Member

lrhn commented Dec 8, 2021

The platform library Enum declaration needs to change in small ways. Those changes should not be a problem to add early, since users can't reach them anyway.

The implementations may also want to have an _Enum class which is updated as well. We'll have to lock down the implementation design first.

@lrhn lrhn added the type-task A well-defined stand-alone task label Dec 9, 2021
@itsjustkevin
Copy link
Contributor

@lrhn was there an associated issue where this work was done? Could we please update this issue?

@lrhn
Copy link
Member

lrhn commented May 6, 2022

I don't think any changes were necessary. Later iterations of the design made it an error to override index, so there was no need to change the existing implementation in order to move that to a superclass.

So, done.

@lrhn lrhn closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-task A well-defined stand-alone task
Projects
None yet
Development

No branches or pull requests

3 participants