Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_builder] test/test_data/transformer_test.dart flaky #1810

Closed
dcharkes opened this issue Dec 12, 2024 · 0 comments · Fixed by #1846
Closed

[native_assets_builder] test/test_data/transformer_test.dart flaky #1810

dcharkes opened this issue Dec 12, 2024 · 0 comments · Fixed by #1846
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:native_assets_builder

Comments

@dcharkes
Copy link
Collaborator

It seems that our in-hook caching solution is broken on the MacOS bot:

❌ test/test_data/transformer_test.dart: transformer caching (failed)

  FINE: 2024-12-12 11:43:40.569175: Try `dart pub outdated` for more information.
  Expected: a string containing 'Transformed 1 files.', 'Reused 9 cached files.' in order
    Actual: 'Transformed 3 files.\n'
              'Reused 7 cached files.\n'
              ''
  
  package:matcher                             expect
  test/test_data/transformer_test.dart 124:7  main.<fn>.<fn>
  ===== asynchronous gap ===========================
  test/helpers.dart 46:5                      inTempDir

Error: 51 tests passed, 1 failed.
Error: Process completed with exit code 1.

https://github.com/dart-lang/native/actions/runs/12295543113/job/34313026197?pr=1809

It's flaky, different amounts of files are cached:

https://github.com/dart-lang/native/actions/runs/12295543113/job/34312641116?pr=1809

I suspect it's because I removed the 1 second sleeps in #1750, but this hook still uses time-stamp hashing.

@dcharkes dcharkes added P1 A high priority bug; for example, a single project is unusable or has many test failures package:native_assets_builder labels Dec 12, 2024
@dcharkes dcharkes self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:native_assets_builder
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant